[tools] Migrate from recharts to MUI X Charts #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is being deployed to Railway 🚅 mui-public/tools-public: ◻️ REMOVED |
oliviertassinari
force-pushed
the
recharts-mui-x-charts
branch
from
89f64b9 to
4e7c27e
Compare
oliviertassinari
force-pushed
the
recharts-mui-x-charts
branch
from
4e7c27e to
5c58755
Compare
oliviertassinari
commented
Feb 8, 2024
Comment on lines
33
to
34
| valueFormatter: ({ value }) => | ||
| Intl.NumberFormat('en', { notation: 'compact' }).format(value), |
There was a problem hiding this comment.
I was expecting
Suggested change
| valueFormatter: ({ value }) => | |
| Intl.NumberFormat('en', { notation: 'compact' }).format(value), | |
| valueFormatter: (value) => | |
| Intl.NumberFormat('en', { notation: 'compact' }).format(value), |
per this demo: https://next.mui.com/x/react-charts/tooltip/#formatting, strange.
There was a problem hiding this comment.
That seems in line with the datagrid valueFormatter
oliviertassinari
force-pushed
the
recharts-mui-x-charts
branch
from
5c58755 to
5c40435
Compare
oliviertassinari
force-pushed
the
recharts-mui-x-charts
branch
from
5c40435 to
b6bafb9
Compare
Janpot
reviewed
Feb 9, 2024
Janpot
reviewed
Feb 9, 2024
alexfauquette
approved these changes
Feb 9, 2024
Janpot
approved these changes
Feb 11, 2024
oliviertassinari
temporarily deployed
to
recharts-mui-x-charts - tools-public PR #147
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was curious to see how we stack up compared to Recharts. A big reason why MUI X Charts should exist is the belief that work on Recharts deserves to be carried on going forward, but it's not happening. So for this to happen, the migration experience should be easy.
Before: https://tools-public.mui.com/prod/pages/npmVersion?package=next
Screen.Recording.2024-02-11.at.14.01.34.mov
After: https://mui-publictools-public-mui-public-pr-147.up.railway.app/prod/pages/npmVersion?package=next
Screen.Recording.2024-02-11.at.16.34.51.mov