[infra] Create reusable workflows #178
Conversation
michelengelen
added
core
|
@oliviertassinari it seems this line broke CircleCI: mui-public/.circleci/config.yml Line 59 in 2ef6ad8 |
|
@michelengelen I ran |
Co-authored-by: Jose C Quintas Jr <juniorquintas@gmail.com> Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
oliviertassinari
force-pushed
the
automation/create-reusable-workflows
branch
from
241d27e to
be6ef9a
Compare
|
I have linked the issue/task/shaping page/conversation at the origin of this PR.
Yeah, It's like I was 🍺 when I pushed that, my diff is stupid 😆. I just noticed because I wanted to fix a Toolpad KPI page, and thought, oh wait, Michal opened a PR, his CI must be broken. I have fixed HEAD and I have rebased this PR on HEAD. |
| issue_number: issueNumber, | ||
| }); | ||
|
|
||
| const repositoryMap = { |
There was a problem hiding this comment.
This mapping between GitHub repository slugs and the product id / product category id looks wrong, issu created #180. Suggestions below to match
There was a problem hiding this comment.
Most of the suggestions given make sense, but the linked code does not contain all of the possible combinations in terms of the repo -> product relation.
Should we define something (like an actual mapping) or keep it as is (with the adjustments from below) for now?
There was a problem hiding this comment.
all of the possible combinations in terms of the repo -> product relation.
Do you have an example of a missing combination? I'm not completely following your point.
There was a problem hiding this comment.
Its the more fine-grained mapping of x-data-grid[-pro/-premium], x-charts, etc since we only have one repository and cannot determine which product is affected based on the limited information we have
There was a problem hiding this comment.
Ah yes agree, in those cases, I think the product category id (https://github.com/mui/material-ui-docs/blob/92ff1fc67c1c999a9c92bdeb0f3ce6bbc173ee58/docs/src/modules/utils/getProductInfoFromUrl.ts#L18) steps in 👍
There was a problem hiding this comment.
Suggestion for the future, we prefer to author scripts in ESM https://github.com/actions/github-script?tab=readme-ov-file#use-esm-import
This introduces reusable workflows to the org.
First one is the closing message as it is the first we can use in the core repo.
This PR should also fix sending this message on issues from the maintainers as well.
See https://github.com/mui/mui-private/issues/360