Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw intermediary nodes matrix #302

Merged
merged 23 commits into from
Jul 15, 2021
Merged

Draw intermediary nodes matrix #302

merged 23 commits into from
Jul 15, 2021

Conversation

gotdairyya
Copy link
Contributor

@gotdairyya gotdairyya commented Jul 13, 2021

This table should show the middle paths of a connectivity query.

To do:

  • add labels for rows
  • add symbols above columns to indicate path position

@gotdairyya gotdairyya requested a review from JackWilb July 13, 2021 14:56
@gotdairyya gotdairyya marked this pull request as ready for review July 13, 2021 19:53
@gotdairyya
Copy link
Contributor Author

@JackWilb this is a super simple implementation of the intermediary node view

I've added issues for the next steps:
#303
#304

@JackWilb JackWilb force-pushed the intermediary-nodes branch from a7efa78 to 715f054 Compare July 14, 2021 00:06
Copy link
Member

@JackWilb JackWilb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like if you run a 2 hop query and then a 3 hop, it doesn't update properly. Maybe that's a more general problem here, that it's not reactive to new update. We'd need to explore that a bit more

Other than that, I've cleaned up some type issues, etc. I also have a couple of questions for you

@JackWilb JackWilb force-pushed the intermediary-nodes branch from 1baa138 to 257063f Compare July 14, 2021 01:50
@gotdairyya gotdairyya requested a review from JackWilb July 14, 2021 14:19
Copy link
Member

@JackWilb JackWilb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bunch of extra space that is added if this div is present. You could also open an issue to address the reactivity of the component since it doesn't seem to update if the path length changes or a query is re-run

With div:
image

Without div:
image

@gotdairyya
Copy link
Contributor Author

Ok so aside from the matrix not updating correctly (pushed to issue #311) I think I have addressed all of the issues
Let me know if I should do anything else before merge?

@gotdairyya gotdairyya requested a review from JackWilb July 14, 2021 23:50
@gotdairyya gotdairyya merged commit 8e1c5f3 into master Jul 15, 2021
@gotdairyya gotdairyya deleted the intermediary-nodes branch July 15, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants