Styling/form labels #101
Merged
Styling/form labels #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o account for these changes
…ent to explain why the invocation is commented out
|
Thank you for getting this done so fast!! |
TimNguyen21
reviewed
Jul 28, 2020
Comment on lines
+141
to
+144
| export const uploadPhoto = async (photo) => { | ||
| try { | ||
| const response = await fetch( | ||
| "https://my-fly-box-api.herokuapp.com/api/v1/images", |
There was a problem hiding this comment.
A good call to move this to the ApiCalls. This make it the proper formatting for the fetch calls.
C-Bandstra
approved these changes
Jul 28, 2020
TimNguyen21
reviewed
Jul 28, 2020
|
|
||
| render() { | ||
| return ( | ||
| <View style={styles.container}> | ||
| <Text style={styles.label}>Fly Name:</Text> |
There was a problem hiding this comment.
Thanks for adding these labels for these input fields in the fly editing and adding page. This make things more understandable for the user when filling out fly information.
There was a problem hiding this comment.
You're welcome! Thanks for bringing this to the group's attention!
TimNguyen21
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s) related to this PR:
Type of change made:
If this submission is a new feature:
Change Log:
Were there any challenges that arose? If so, how were they addressed?
Technical Debt:
Testing:
Test coverage = 45.93%