-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove party cohort code. #1755
Conversation
This looks good - if you're happy with my amends:
|
6cf128b
to
907235c
Compare
We store/use the figures returned externally. Some of the tests are therefore now only testing that what is stored in the fixture is displayed, rather than any calculations involved.
- Make clearer where delays are twfy-votes fault
- Now importing quite a lot. - Making commit manual for efficiency.
a3d854d
to
1482667
Compare
Feels like I have to recombine/refactor those two scripts, given how much they do overlap :) |
I've recombined these with a switch in a fixup commit - if that's good I can squish before merging. |
This restores the json votes/divisions loader, removed from json2db as a seperate file for speedy dev setup.
32b349f
to
335f6cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One query, looks fine otherwise. More generally, though, just to check I understand - what's the reason to use this over the xml2db.pl import of divisions? Do you want to get votes in separately?
Sure - basically it's a speed of creating a working environment from scratch so the codespace prebuild takes an hour rather than a day. For debates, I don't mind having a subsection (loading just one month), but for double checking the voting records I want to have all relevant votes, and to do that means downloading and importing thousands of days of debates and votes, which significantly increases the build time. Ideally, I'd just do that - but given the dev setup was working with the json import, and twfy-votes has continuity with the old format - may as well keep it. |
I can't approve my own PR, but happy with it! |
We store/use the figures returned externally. Some of the tests are therefore now only testing that what is stored in the fixture is displayed, rather than any calculations involved. Should fix #1742. Is on top of other PRs.