Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove party cohort code. #1755

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Remove party cohort code. #1755

merged 4 commits into from
Feb 21, 2024

Conversation

dracos
Copy link
Member

@dracos dracos commented Dec 19, 2023

We store/use the figures returned externally. Some of the tests are therefore now only testing that what is stored in the fixture is displayed, rather than any calculations involved. Should fix #1742. Is on top of other PRs.

@dracos dracos requested a review from ajparsons December 19, 2023 11:28
@ajparsons
Copy link
Contributor

This looks good - if you're happy with my amends:

  • added autocommit settings when loading alignment information to speed that up.
  • readded vote/division populator for dev setup from json.

@dracos dracos force-pushed the use-twfy-json-policy-json branch from 6cf128b to 907235c Compare January 16, 2024 16:40
@dracos dracos changed the base branch from use-twfy-json-policy-json to master January 16, 2024 17:11
dracos and others added 3 commits January 16, 2024 17:12
We store/use the figures returned externally. Some of the tests are
therefore now only testing that what is stored in the fixture is
displayed, rather than any calculations involved.
- Make clearer where delays are twfy-votes fault
- Now importing quite a lot.
- Making commit manual for efficiency.
@dracos dracos force-pushed the new-party-comparison branch from a3d854d to 1482667 Compare January 16, 2024 17:12
@dracos
Copy link
Member Author

dracos commented Jan 16, 2024

Feels like I have to recombine/refactor those two scripts, given how much they do overlap :)

@ajparsons
Copy link
Contributor

Feels like I have to recombine/refactor those two scripts, given how much they do overlap :)

I've recombined these with a switch in a fixup commit - if that's good I can squish before merging.

@ajparsons ajparsons mentioned this pull request Feb 6, 2024
This restores the json votes/divisions loader, removed from json2db
as a seperate file for speedy dev setup.
@ajparsons ajparsons force-pushed the new-party-comparison branch from 32b349f to 335f6cb Compare February 8, 2024 16:17
Copy link
Member Author

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One query, looks fine otherwise. More generally, though, just to check I understand - what's the reason to use this over the xml2db.pl import of divisions? Do you want to get votes in separately?

@ajparsons
Copy link
Contributor

Sure - basically it's a speed of creating a working environment from scratch so the codespace prebuild takes an hour rather than a day.

For debates, I don't mind having a subsection (loading just one month), but for double checking the voting records I want to have all relevant votes, and to do that means downloading and importing thousands of days of debates and votes, which significantly increases the build time.

Ideally, I'd just do that - but given the dev setup was working with the json import, and twfy-votes has continuity with the old format - may as well keep it.

@dracos
Copy link
Member Author

dracos commented Feb 8, 2024

I can't approve my own PR, but happy with it!

@ajparsons ajparsons merged commit 285109c into master Feb 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch TheyWorkForYou’s internal calculation of comparisons to twfy-votes
2 participants