Switch from using teams backend to nais api #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NAIS-api uses a grpc client for internal communication. This also upgrades the project to Go 1.22 because nais-api requires Go 1.22.
kimtore
requested changes
Feb 21, 2024
pkg/hookd/config/config.go
Outdated
| @@ -32,8 +32,8 @@ type Config struct { | |||
| LogLinkFormatter string `json:"log-link-formatter"` | |||
| MetricsPath string `json:"metrics-path"` | |||
| ProvisionKey string `json:"provision-key"` | |||
| TeamsAPIKey string `json:"teams-api-key"` | |||
| TeamsURL string `json:"teams-url"` | |||
| NaisAPITarget string `json:"nais-api-target"` | |||
There was a problem hiding this comment.
Rename to nais-api-address
pkg/hookd/config/config.go
Outdated
| TeamsAPIKey string `json:"teams-api-key"` | ||
| TeamsURL string `json:"teams-url"` | ||
| NaisAPITarget string `json:"nais-api-target"` | ||
| NaisAPIInsecure bool `json:"nais-api-insecure"` |
There was a problem hiding this comment.
What does "insecure" mean?
I don't mind having "insecure" in the name, but I'd prefer if the option reflected what it actually does.
pkg/naisapi/naisapi.go
Outdated
| client protoapi.TeamsClient | ||
| } | ||
|
|
||
| func New(target string, insecureConnection bool) (*Client, error) { |
kimtore
approved these changes
Feb 21, 2024
|
The package in |
kimtore
requested changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NAIS-api uses a grpc client for internal communication.
This also upgrades the project to Go 1.22 because nais-api requires Go 1.22.
Denne krever at nais-api er på plass. Så før merging og utrulling, så må tenants utenom ci-nais og dev-nais skru av hookd reconcile i Fasit.