Write deployments to nais/api using gRPC #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relevant changes: - Use apiclient package from nais/api instead of generating and wrapping the client - Enrich deployment request to include deployer username and trigger URL - All errors that occurs when writing deployments to nais/api will trigger log entries, and will not abort any other process Other changes: - Bump version of staticcheck to make it run (the version used was broken) - Fixed warning on using Errorf without constant format strings in touched files Co-authored-by: Thomas Krampl <thomas.siegfried.krampl@nav.no>
|
If this looks good, we would like to merge this after relevant changes in nais/api. |
kimtore
approved these changes
Jan 31, 2025
christeredvartsen
added a commit
that referenced
this pull request
Feb 3, 2025
Now that hookd stores deployments in Nais API using gRPC the /deployments endpoint is no longer being used. #269 Co-authored-by: Thomas Krampl <thomas.siegfried.krampl@nav.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initiative: https://github.com/nais/system/blob/deploy_history/tooling/deploy-historikk/README.md
Relevant changes:
Other changes:
We will remove code that is no longer necessary (for instance the deployments REST API) once this hits production.