Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support k8s secrets #23

Closed
wants to merge 4 commits into from
Closed

Conversation

ffais
Copy link

@ffais ffais commented Jun 24, 2024

Added support for kubernetes secrets as mysql root credentials provider.

This PR is needed.

Copy link
Owner

@nakamasato nakamasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! Just one comment!

Signed-off-by: ffais <ffais@fbk.eu>
@logileifs
Copy link

@nakamasato ffais has added the create verb. Can this PR be merged now?

@sprasad09
Copy link

@nakamasato can we please merge this PR if looks good. Thanks!

@nakamasato
Copy link
Owner

Sorry for the late reply 🙏 i'm gonna merge it.

Copy link
Owner

@nakamasato nakamasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't use template under crds dir. so let me try fixing it in another pr.

@nakamasato
Copy link
Owner

I've updated with #25 sorry for taking so long 🙏

@nakamasato nakamasato closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants