Refactorization #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cojapacze
commented
Jun 3, 2019
cojapacze
commented
- Add .eslintrc with best practices and simply update js code to meet current standards
- Remove unused functions and other artifacts
- Change names and reorganize code
- Add support for asyncBlocking in Chromium with fallback to sync HTTP lookup
- Use native communication by default
added 6 commits
June 3, 2019 16:15
Add .eslintrc with best practices and simply update js code to meet current standards
- remove unused resetRequestListener
- Remove currentRequestListener artifact - Use consts for crucial settings - Refactor names
- change code order
- Add support for asyncBlocking in chromium with fallback to sync HTTP lookup - Use native communication by default
- change names from 'compat' to 'unified' - remove unnecessary functions - try to keep vars alphabetically ordered - use compact notation - remove magic numbers - use semantic console output
|
Thanks for the PR. Generally my policy is that when bugs are fixed, a test should be added so that we don't have regressions later. In this PR's case, it would be useful to have a Bash script (maybe call it [1] We'll probably add more tests to this Bash script later, e.g. things that run stuff in a browser. |
|
Any particular reason why |
|
The HTTPS Everywhere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.