Rename name-generator to namegraph #328
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightwalker-eth
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
@djstrong Hey thanks! From a purely code review perspective this all looks good to me 👍 I note how the CI shows an error on this PR currently. Is this something that would fix itself after we deploy or something we should fix first? Appreciate your advice.
|
@lightwalker-eth Tests fail because I changed the name of S3 bucket in code but not in AWS. If @BanaSeba changes these resources tests should pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.