Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new hp888 transformers #90

Merged
merged 6 commits into from
Sep 24, 2024
Merged

new hp888 transformers #90

merged 6 commits into from
Sep 24, 2024

Conversation

Animowany
Copy link
Contributor

No description provided.

Copy link
Collaborator

@EpicPlayerA10 EpicPlayerA10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format the code in 2 spaces indent. I've added the .editorconfig recently to apply this 2 spaces indent automatically using IntelliJ.

Also it would be nice if you added a sample test for your transformers ;)

@Janmm14
Copy link
Contributor

Janmm14 commented Sep 22, 2024

Will the key always end with "=="?

@EpicPlayerA10
Copy link
Collaborator

May I expect test classes samples? You can pick like 2-3 classes from jar and put it into test directory and connect them. Or perhaps you can't share anything.

Repository owner deleted a comment from github-advanced-security bot Sep 22, 2024
Repository owner deleted a comment from sonarqubecloud bot Sep 22, 2024
@EpicPlayerA10
Copy link
Collaborator

Then how I can test these transformers?

@narumii

This comment was marked as off-topic.

@EpicPlayerA10 EpicPlayerA10 merged commit db1e024 into narumii:master Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants