-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDSC-3797: Added an option for concatenation for custom downloads via Harmony #1693
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1693 +/- ##
=======================================
Coverage 91.90% 91.90%
=======================================
Files 724 726 +2
Lines 19361 19404 +43
Branches 4550 4570 +20
=======================================
+ Hits 17793 17834 +41
- Misses 1432 1434 +2
Partials 136 136 ☔ View full report in Codecov by Sentry. |
Do you plan on adding reproduction steps? What collection did you use for testing? I'd like to take a look locally at some point today. |
1 similar comment
Do you plan on adding reproduction steps? What collection did you use for testing? I'd like to take a look locally at some point today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Trevor, reproduction steps need to be added. Those are also useful when you end up writing the test session
static/src/js/util/accessMethods/__tests__/buildAccessMethods.test.js
Outdated
Show resolved
Hide resolved
…t undefined when the lambda job is created.
static/src/js/util/accessMethods/__tests__/supportsConcatenation.test.js
Show resolved
Hide resolved
…gation exists but concatenate does not.
approved per changes mentioned in the PR meeting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When checking the Enable Concatenation checkbox and refreshing the page, the form is not remembering the selected checkbox like it does with the other form fields. You need to be sure to put the value into the URL and populate it from the URL.
serverless/src/submitHarmonyOrder/__tests__/constructOrderPayload.test.js
Outdated
Show resolved
Hide resolved
…n test for constructing the orderPayload
…url works as expected.
…oncatenate initially.
I added this as well as tests for it. |
static/src/js/util/accessMethods/__tests__/defaultConcatenation.test.js
Outdated
Show resolved
Hide resolved
static/src/js/util/accessMethods/__tests__/buildAccessMethods.test.js
Outdated
Show resolved
Hide resolved
…n.test.js Co-authored-by: Ed Olivares <34591886+eudoroolivares2016@users.noreply.github.com>
…into EDSC-3797
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be sure to update https://wiki.earthdata.nasa.gov/display/EDSC/Earthdata+Search+URL+Parameters with the new URL parameter
serverless/src/submitHarmonyOrder/__tests__/constructOrderPayload.test.js
Outdated
Show resolved
Hide resolved
…into EDSC-3797
serverless/src/submitHarmonyOrder/__tests__/constructOrderPayload.test.js
Outdated
Show resolved
Hide resolved
serverless/src/submitHarmonyOrder/__tests__/constructOrderPayload.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
When running locally, the submission to Harmony fails because SQS isn't mocked in our dev environment.
After following the steps in the description, I followed these steps to submit the order to Harmony:
- Make an
event.json
file that looks like this:
{
"Records": [
{
"body": {
"accessToken": "",
"id":
}
}
]
}
- Using TableTool or similar connected to your local Postgres DB, copy the
token
value from the last (newest) row in theretrievals
table. Paste it into the empty quotes foraccessToken
in the JSON. - Copy the
id
value from the last row of theretrieval_orders
table. Paste it intoevent.json
as the value forid
. Save theevent.json
file. - The value for
body
needs to be stringified, but everything outside of that needs to be valid JSON. Run these commands to make that conversion:
export body=$(jq -r '.Records[0].body' event.json)
jq -r '.Records[0].body = env.body' event.json | sed 's/\\n//g' > event_string.json
- Run the local lambda for submitting the Harmony order with that JSON payload:
npm run invoke-local -- --function submitHarmonyOrder --path ./event_string.json
- Confirm the order was submitted at https://harmony.uat.earthdata.nasa.gov/workflow-ui
Overview
What is the feature?
Added an option for concatenation for custom downloads via Harmony
Please summarize the feature or fix.
Added checkbox for concatenation option as well as setting the checkbox to be checked if defaultConcatenation is true in the cmr request.
What is the Solution?
What areas of the application does this impact?
List impacted areas.
Testing
Reproduction steps
Attachments
Checklist