EDSC-3925: Snyk Vulnerabilities, Earthdata Search #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rowserify-sign` on the `crypto-browserify` dep
eudoroolivares2016
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1695 +/- ##
==========================================
- Coverage 91.95% 91.94% -0.02%
==========================================
Files 726 725 -1
Lines 19405 19349 -56
Branches 4571 4562 -9
==========================================
- Hits 17844 17790 -54
+ Misses 1425 1423 -2
Partials 136 136 ☔ View full report in Codecov by Sentry. |
eudoroolivares2016
requested review from
Bccorb,
bnp26,
rushgeo,
dpesall and
daniel-zamora
dpesall
approved these changes
Nov 22, 2023
| * Search the Nominatim OpenStreetMaps API endpoint | ||
| * @param {query} query The spatial query provided from the user | ||
| */ | ||
| const nominatimGeocode = async (query) => { |
There was a problem hiding this comment.
Double check that may also remove the geocodingService: ${env:GEOCODING_SERVICE, 'nominatim'} in serverless.yaml
There was a problem hiding this comment.
We can remove these but, we should also make sure as this propagates to remove the env vars from bamboo as well
daniel-zamora
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
Fixes a few Snyk vulnerabilities being reported on upstream dependencies
What is the Solution?
npm upgrade browserify-signas suggested by the maintainers on`crypto-browsify'(see PR)
update serverless with the newest version
Remove the
googlemaps/google-maps-services-jsdependency from EDSC (spatial-autocompletes) and its associated source code mainly undoing SC added in this PR this use-case was never being utilizedWhat areas of the application does this impact?
List impacted areas.
Testing
Reproduction steps
Pull down latest and run
npm irun thesnyk testcli tool. Ensure that the reported dependencies in this ticket are not reported. Regression test EDSC to ensure application continues to function as expectedAttachments
Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.
Checklist