-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDSC-3923: Add clientId to EDD startDownload link #1696
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1696 +/- ##
==========================================
+ Coverage 91.87% 91.94% +0.06%
==========================================
Files 725 725
Lines 19349 19349
Branches 4562 4562
==========================================
+ Hits 17777 17790 +13
+ Misses 1436 1423 -13
Partials 136 136 ☔ View full report in Codecov by Sentry. |
The clientId needs to be more specific, just using the env doesn't tell us EDSC sent the user to EDD. I'd look into the clientIds that we send to CMR and see if we can reuse anything from that logic/config |
to avoid masking it in GH test runs
The latest commit fixes the tests by using the correct |
Mocking |
Overview
What is the feature?
Add the
clientId
parameter to thestartDownload
link to track which EDSC environment initializes the downloadWhat is the Solution?
Use the
env
property from the Application config for theclientId
parameter and place it in the EDD URL.What areas of the application does this impact?
EDD link generation.
Testing
&clientId=eed-edsc-dev-serverless-client
after the mockedauthToken
Checklist