Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-3890: EDSC shows empty granules for the collections list after hitting back to search on collections with customizable options #1697

Merged
merged 6 commits into from
Dec 12, 2023

Conversation

bnp26
Copy link
Collaborator

@bnp26 bnp26 commented Nov 29, 2023

Overview

What is the feature?

Fixed bug where clicking Refine your search on a collection with too many granules loads 0 Granule collections with no names.

What is the Solution?

Added updatePath boolean to the PortalLinkContainer that renders the "Refine your search" button so that we reload the page when navigating after clicking the button.

What areas of the application does this impact?

Just EDSC ChunkedOrderModal.js

Testing

Reproduction steps

  • Environment for testing: UAT
  • Collection to test with: C1225776654-ASF
  1. go to http://localhost:8080/search?ee=uat&q=C1225776654-ASF
  2. Click on the first collection
  3. Click Download All
  4. Select the first Harmony access method.
  5. Click Download Data
  6. Click Refine your search
  7. Observe the page loading all the collections again and that all URL params are maintained.

Attachments

Screenshot 2023-11-29 at 3 53 42 PM Screenshot 2023-11-29 at 3 53 48 PM Screenshot 2023-11-29 at 3 53 59 PM Screenshot 2023-11-29 at 3 54 05 PM Screenshot 2023-11-29 at 3 54 11 PM

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works (No tests to add, no new logic)
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (N/A)
  • I have made corresponding changes to the documentation (N/A)
  • My changes generate no new warnings

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b6b38b) 91.94% compared to head (3eca515) 91.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1697      +/-   ##
==========================================
- Coverage   91.94%   91.93%   -0.01%     
==========================================
  Files         725      725              
  Lines       19349    19349              
  Branches     4562     4562              
==========================================
- Hits        17790    17789       -1     
- Misses       1423     1424       +1     
  Partials      136      136              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eudoroolivares2016 eudoroolivares2016 changed the title Edsc 3890 EDSC-3890: EDSC shows empty granules for the collections list after hitting back to search on collections with customizable options Dec 1, 2023
@bnp26 bnp26 marked this pull request as ready for review December 6, 2023 17:50
@bnp26 bnp26 merged commit bdb411f into main Dec 12, 2023
9 checks passed
@bnp26 bnp26 deleted the EDSC-3890 branch December 12, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants