Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-3971: Adding Feature Toggle for cmr-ordering and the EDSC database during down-time #1707

Merged
merged 14 commits into from
Jan 25, 2024

Conversation

eudoroolivares2016
Copy link
Contributor

@eudoroolivares2016 eudoroolivares2016 commented Jan 15, 2024

Overview

What is the feature?

Add feature toggle for cmr-ordering so that we can safely migrate that database
Adds feature toggle for behavior that requires the EDSC database

What is the Solution?

Adding the feature toggles and disabling behavior from EDSC if they are set to true

What areas of the application does this impact?

ordering for the order feature toggle and all database interactions as this disabled the secondary toolbar

Testing

Set the toggles in the process.env in your .zshrc or your .bashrc for the database toggle and set the toggles for cmr-ordering and the database related rendered components in your override.static.config.json file

Ensure your database is either deleted or otherwise turned off I did so using: pg_ctl -D /usr/local/var/postgresql@14 stop

To test colormaps toggle against prod locally use: C1996881146-POCLOUD

To test cmr-ordering toggle against prod locally use: C1299783631-LPDAAC_ECS

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb28989) 91.94% compared to head (15ea0a3) 90.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1707      +/-   ##
==========================================
- Coverage   91.94%   90.42%   -1.53%     
==========================================
  Files         725      725              
  Lines       19354    19379      +25     
  Branches     4561     4569       +8     
==========================================
- Hits        17796    17523     -273     
- Misses       1422     1686     +264     
- Partials      136      170      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eudoroolivares2016 eudoroolivares2016 changed the title EDSC-3971: Adding Feature Toggle for cmr-ordering EDSC-3971: Adding Feature Toggle for cmr-ordering and the EDSC database during down=-time Jan 22, 2024
@eudoroolivares2016 eudoroolivares2016 marked this pull request as ready for review January 22, 2024 14:35
@eudoroolivares2016 eudoroolivares2016 changed the title EDSC-3971: Adding Feature Toggle for cmr-ordering and the EDSC database during down=-time EDSC-3971: Adding Feature Toggle for cmr-ordering and the EDSC database during down-time Jan 22, 2024
serverless/src/getColorMap/handler.js Outdated Show resolved Hide resolved
@@ -79,8 +81,6 @@ dockerRun() {
-e "CLOUDFRONT_BUCKET_NAME=$bamboo_CLOUDFRONT_BUCKET_NAME" \
-e "COLORMAP_JOB_ENABLED=$bamboo_COLORMAP_JOB_ENABLED" \
-e "DB_INSTANCE_CLASS=$bamboo_DB_INSTANCE_CLASS" \
-e "GEOCODING_INCLUDE_POLYGONS=$bamboo_GEOCODING_INCLUDE_POLYGONS" \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are no longer being used and should have been removed in a previous PR

@eudoroolivares2016 eudoroolivares2016 merged commit d4da4a8 into main Jan 25, 2024
11 checks passed
@eudoroolivares2016 eudoroolivares2016 deleted the EDSC-3971 branch January 25, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants