Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-4000: Install GSA's Digital Analytics Program (DAP) tracking code #1718

Merged
merged 11 commits into from
Feb 23, 2024

Conversation

bnp26
Copy link
Collaborator

@bnp26 bnp26 commented Feb 21, 2024

Overview

What is the feature?

Added dap script

What is the Solution?

Summarize what you changed.

What areas of the application does this impact?

Testing

Reproduction steps

Attachments

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (f419770) to head (b142a9a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1718   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files         725      725           
  Lines       19380    19380           
  Branches     4586     4586           
=======================================
  Hits        17821    17821           
  Misses       1423     1423           
  Partials      136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnp26 bnp26 requested review from trevorlang and dpesall February 21, 2024 19:43
@eudoroolivares2016 eudoroolivares2016 changed the title EDSC-4000: added dap script to wrapper.html EDSC-4000: Install GSA's Digital Analytics Program (DAP) tracking code on EDSC Feb 21, 2024
@eudoroolivares2016 eudoroolivares2016 changed the title EDSC-4000: Install GSA's Digital Analytics Program (DAP) tracking code on EDSC EDSC-4000: Install GSA's Digital Analytics Program (DAP) tracking code Feb 21, 2024
static/src/partials/body.html Outdated Show resolved Hide resolved
@@ -124,3 +124,7 @@ <h3 class="fallback-page__heading">Your browser is out of date</h3>
></script>
<script type="text/javascript">feedback.init({ showIcon: false });</script>
<% } %>
<script async type="text/javascript"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these analytics only be turned on if we are not in dev mode?

Copy link
Contributor

@eudoroolivares2016 eudoroolivares2016 Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was mentioned during standup that it was okay for this to be on during development mode and that this change is has a hard deadline.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay so discussed this a bit in some DM's if we look at what we did for google analytics I think that is really what we would be looking to replicate here or similar to the feedback app. It would be preferred that we didn't have this script running while in development mode

Co-authored-by: Ed Olivares <34591886+eudoroolivares2016@users.noreply.github.com>
Copy link
Contributor

@eudoroolivares2016 eudoroolivares2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we look at what we did for google analytics I think that is really what we would be looking to replicate here or similar to the feedback app. It would be preferred that we didn't have this script running while in development mode because otherwise 1 we are going to pollute their metrics and we have additional scripts being worked during development mode

Copy link
Contributor

@eudoroolivares2016 eudoroolivares2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with using env here I probably think it should be its own variable though

@bnp26 bnp26 merged commit 648e617 into main Feb 23, 2024
11 checks passed
@bnp26 bnp26 deleted the EDSC-4000 branch February 23, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants