-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDSC-4000: Install GSA's Digital Analytics Program (DAP) tracking code #1718
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1718 +/- ##
=======================================
Coverage 91.95% 91.95%
=======================================
Files 725 725
Lines 19380 19380
Branches 4586 4586
=======================================
Hits 17821 17821
Misses 1423 1423
Partials 136 136 ☔ View full report in Codecov by Sentry. |
static/src/partials/body.html
Outdated
@@ -124,3 +124,7 @@ <h3 class="fallback-page__heading">Your browser is out of date</h3> | |||
></script> | |||
<script type="text/javascript">feedback.init({ showIcon: false });</script> | |||
<% } %> | |||
<script async type="text/javascript" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these analytics only be turned on if we are not in dev mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was mentioned during standup that it was okay for this to be on during development mode and that this change is has a hard deadline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay so discussed this a bit in some DM's if we look at what we did for google analytics I think that is really what we would be looking to replicate here or similar to the feedback app. It would be preferred that we didn't have this script running while in development mode
Co-authored-by: Ed Olivares <34591886+eudoroolivares2016@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we look at what we did for google analytics I think that is really what we would be looking to replicate here or similar to the feedback app. It would be preferred that we didn't have this script running while in development mode because otherwise 1 we are going to pollute their metrics and we have additional scripts being worked during development mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with using env
here I probably think it should be its own variable though
Overview
What is the feature?
Added dap script
What is the Solution?
Summarize what you changed.
What areas of the application does this impact?
Testing
Reproduction steps
ensure https://dap.digitalgov.gov/Universal-Federated-Analytics-Min.js?agency=NASA&subagency=GSFC is in the network tab.
Attachments
Checklist