EDSC-4076: Integrate a linter for react-testing-library before the number of those gets too large in EDSC

[daniel-zamora]

Overview

What is the feature?

Adds react testing library eslint plugin to edsc

What is the Solution?

Added edsc specific configs to the lint config, the shared linter config updated version, and updated all the tests that were experiencing new linter errors

What areas of the application does this impact?

Component tests that use react testing library.

Testing

Reproduction steps

npm run lint

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

• I have added automated tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.80%. Comparing base (67a97c3) to head (709855b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1844      +/-   ##
==========================================
+ Coverage   93.78%   93.80%   +0.01%     
==========================================
  Files         778      778              
  Lines       18900    18902       +2     
  Branches     4885     4886       +1     
==========================================
+ Hits        17726    17731       +5     
+ Misses       1099     1095       -4     
- Partials       75       76       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eudoroolivares2016]

We do need to figure out why code-cov is missing some files

[eudoroolivares2016]

Should these be done in the linter package? otherwise EDSC might have a different setup than say MMT. Some of these feel like they aren't bad to ignore though I understand that it would make this PR even larger some comments on why we're doing these would be good to have though

[daniel-zamora]

I think that is the point of the eslintrc, not all repos will want this, we need to exclude tests that haven't been converted from enzyme etc.

[macrouch]

Add a comment explaining why these rules are being ignored

[trevorlang]

I could use a little background as to why all of these rules are being ignored. A comment explaining might be enough 😄

[macrouch]

Add a comment explaining why these rules are being ignored