-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSRC-62: Document block #1638
DSRC-62: Document block #1638
Conversation
There is a DocumentSerializer: https://github.com/wagtail/wagtail/blob/5a1ba5abe2511aad29d927cef85e5a73916f2375/wagtail/documents/api/v2/serializers.py I can't remember where the design is but I think we need the file name, mime type and file size. The model looks like it has a few of these fields ready to go: https://github.com/wagtail/wagtail/blob/5a1ba5abe2511aad29d927cef85e5a73916f2375/wagtail/documents/models.py#L40 I think there was a requirement to allow a list of downloads - was this your understanding as well? |
Another thought - are these going into article pages or the yet-to-be-defined "standard page"? |
Perfect 😎
I haven't seen that anywhere on any of the tickets, just the ability to add one file... Was it in a discussion somewhere? |
We have too many tickets per component! 😅 The design one mentions one or more: There is a design somewhere that shows a list as well but I've only seen it on other's screens. |
Co-authored-by: Andrew Hosgood <andrew.hosgood@nationalarchives.gov.uk>
Ticket URL: DSRC-62
About these changes
Adds a
DocumentBlock
to theArticlePageStreamBlock
so that you can add a link to a document with your desired text.How to check these changes
In the CMS:
Page view:
Document view:
In the API:
Before assigning to reviewer, please make sure you have
Merging PR guidance
Follow docs\developer-guide\contributing.md
Deployment guidance
Follow docs\infra\environments.md