Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSRC-49: Do and Don't list #1662

Merged
merged 4 commits into from
Jun 28, 2024
Merged

DSRC-49: Do and Don't list #1662

merged 4 commits into from
Jun 28, 2024

Conversation

jamesbiggs
Copy link
Collaborator

@jamesbiggs jamesbiggs commented Jun 26, 2024

Ticket URL: DSRC-49

About these changes

Adds a "dos and don'ts" block

In the CMS:
image

In the API:
image

Users can currently add an infinite amount, I think once the work is done on all/most blocks, we'll be going back over to fine tune the wording of labels, the min/max limit of certain blocks, the word count, etc.

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes
  • Ensured that PR includes only commits relevant to the ticket
  • Waited for all CI jobs to pass before requesting a review
  • Added/updated tests and documentation where relevant

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

@jamesbiggs jamesbiggs requested a review from ahosgood June 26, 2024 10:55
@jamesbiggs jamesbiggs merged commit a367996 into develop Jun 28, 2024
17 checks passed
@jamesbiggs jamesbiggs deleted the feature/DSRC-49-do-and-dont branch June 28, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants