Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the default image rendition background colour white #1761

Merged
merged 23 commits into from
Dec 16, 2024

Conversation

ahosgood
Copy link
Member

@ahosgood ahosgood commented Dec 12, 2024

E.g. image for "Report on the British Indian Army, 1943" from https://tna.dblclk.dev/explore-the-collection/stories/ shows the animated loader behind it

@ahosgood ahosgood requested a review from jamesbiggs December 12, 2024 10:54
Copy link
Collaborator

@jamesbiggs jamesbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, just one spelling change 😃

ahosgood and others added 4 commits December 16, 2024 11:06
Co-authored-by: James Biggs <62654785+jamesbiggs@users.noreply.github.com>
Co-authored-by: James Biggs <62654785+jamesbiggs@users.noreply.github.com>
Co-authored-by: James Biggs <62654785+jamesbiggs@users.noreply.github.com>
Copy link
Collaborator

@jamesbiggs jamesbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ahosgood ahosgood merged commit ec1e98f into develop Dec 16, 2024
7 checks passed
@ahosgood ahosgood deleted the feature/image-backgrounds branch December 16, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants