Skip to content

Commit

Permalink
Move footer out of WIP
Browse files Browse the repository at this point in the history
  • Loading branch information
ahosgood committed Aug 8, 2023
1 parent 54a03cb commit 4092584
Show file tree
Hide file tree
Showing 5 changed files with 36 additions and 10 deletions.
16 changes: 16 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,27 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added
### Changed

### Deprecated
### Removed
### Fixed
### Security

## [v0.1.11-prerelease] - 2023-08-08

### Added

- Footer component moved out of work in progress ready to test in beta
- Hero component has a small amount of support for users who prefer more contrast

### Changed

- Removed vendor-specific CSS values for IE10 from grid classes (`display: -ms-flexbox;`)
- Hero component background images now require a width and height
### Fixed

- The fallback font family for `supria-sans-condensed` was changed to `sans-serif` rather than `monospace`

## [v0.1.10-prerelease] - 2023-07-14

### Added
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nationalarchives/frontend",
"version": "0.1.10-prerelease",
"version": "0.1.11-prerelease",
"description": "The National Archives frontend styles",
"scripts": {
"start": "storybook dev -p 6006",
Expand Down
22 changes: 16 additions & 6 deletions src/nationalarchives/components/footer/_index.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@use "../../utilities/global"; // To get %tna-invert
@use "../../variables/colour" as colourVars;
@use "../../tools/colour";
@use "../../tools/media";

Expand All @@ -10,10 +11,14 @@
@extend %tna-invert;

&__link {
color: inherit;
&,
&:visited {
color: inherit;
}

&:hover {
@include colour.colour-font("link");
// @include colour.colour-font("link");
color: colourVars.$tna-blue;
}
}

Expand Down Expand Up @@ -108,12 +113,17 @@
&__govuk-link {
display: inline-block;

color: inherit;
fill: #fff;
&,
&:visited {
color: inherit;
fill: #fff;
}

&:hover {
@include colour.colour-font("link");
@include colour.colour-fill("link");
// @include colour.colour-font("link");
// @include colour.colour-fill("link");
color: colourVars.$tna-blue;
fill: colourVars.$tna-blue;
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/nationalarchives/components/footer/footer.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Object.keys(argTypes).forEach((argType) => {
});

export default {
title: "Work in progress/Components/Footer",
title: "Components/Footer",
argTypes,
};

Expand Down

0 comments on commit 4092584

Please sign in to comment.