Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding conditional dependencies to our data model #439

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

aditigopalan
Copy link
Contributor

@aditigopalan aditigopalan commented Jul 16, 2024

Pulled this table from the visualize/attributes endpoint of the schematic API with help from FAIR. I currently have it stored in data-models, allowing us to integrate this information directly into the portal for documentation purposes.

Linking #442

@adamjtaylor lmk if there is a better spot for this

@aditigopalan aditigopalan requested a review from adamjtaylor July 16, 2024 17:16
Copy link
Contributor

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much!

@adamjtaylor
Copy link
Contributor

adamjtaylor commented Jul 22, 2024

As agreed with @aditigopalan, to rename as HTAN.dependencies.csv or HTAN.conditionals.csv or similar to keep the naming pattern.

@aditigopalan aditigopalan merged commit 165c9dd into main Jul 22, 2024
@aditigopalan aditigopalan deleted the conditional-if-table branch July 22, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants