Put fast-auth-signer in iframe for authentication process. #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benmalcom
added
the
enhancement
calebjacob
requested changes
Jan 17, 2024
|
Hey @esaminu what intended change will this PR have on UX? |
|
@charleslavon @calebjacob These changes will still allow users to access other wallets via the "Connect Wallet" button in the iframe which will open wallet selector by redirecting with a query param cc @nall-near |
benmalcom
force-pushed
the
update/put-signer-in-iframe
branch
from
5f86c28 to
e87180f
Compare
benmalcom
force-pushed
the
update/put-signer-in-iframe
branch
from
23f37e2 to
58b54cd
Compare
…ersion chore: show wallet selector on query params value #2: chore: make request authentication support login and create account modal chore: update ignore files chore: remote wallet url chore: show wallet modal from event chore: bump near fastauth wallet version fix: fix lock error
benmalcom
force-pushed
the
update/put-signer-in-iframe
branch
from
c5687a5 to
8e6635b
Compare
This was referenced Feb 20, 2024
charleslavon
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some little changes to
DesktopNavigation,useSignInRedirectandvmInitializerfiles to initiate our POC, which is an iframe/modal based authentication instead of the page-based authentication method we currently have.cc: @esaminu