Add Call To Action Button on Transfer Wizard Doc #3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-haynes
requested changes
Jan 10, 2024
| render={() => ( | ||
| <TransferWizardWrapper | ||
| account={account} | ||
| onTransfer={this.handleTransferClick} |
There was a problem hiding this comment.
Let's please invoke this in an arrow function to avoid potential binding issues, e.g.:
onTransfer={() => this.handleTransferClick()}
andy-haynes
approved these changes
Jan 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains minor change on transfer wizard doc to include call to action button at the bottom of the doc, allowing user to initiate the transfer wizard from doc page:
This button will only be visible if there is at least one account already signed in.
near/wallet-experience#15