-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to fastnear #355
migrate to fastnear #355
Conversation
@race-of-sloths please, include my PR in the Race |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, I've highlighted a few places to note. However, nothing critical so far, so we're good to merge even without addressing the things I've mentioned in the PR review. Great job!
@@ -20,8 +20,7 @@ pub struct GenesisInfo { | |||
impl GenesisInfo { | |||
pub async fn get( | |||
near_rpc_client: &crate::utils::JsonRpcClient, | |||
s3_client: &near_lake_framework::s3_fetchers::LakeS3Client, | |||
s3_bucket_name: &str, | |||
fastnear_client: &near_lake_framework::fastnear_client::FastNearClient, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change basically indicates disadvantages we are about to introduce to the near-lake-framework
. I would expect near_lake_framework::Client
here that could work with either Lake data or FastNear data. We need to rethink the changes on the framework. Though, it is not a blocker for this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will improve it on the near-lake-framework side.
@kobayurii Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 2! We would appreciate your feedback or contribution idea that you can submit here What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
Hey, unfortunately, we skipped this PR as our bot was blocked :( But we extended the time range so should pass just now. Sorry for the inconvenience. @race-of-sloths include |
🥁 Score it! @khorolets, please score the PR with |
This PR brings significant improvements to the read_rpc server after adding
fastnear
as an alternative data provider for NEAR Lake (near/near-lake-framework-rs#109).Improvements to read_rpc Server:
These enhancements contribute to better overall performance of the read_rpc server, resulting in higher reliability, faster response times, and a more resilient system.