Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to fastnear #355

Merged
merged 4 commits into from
Oct 3, 2024
Merged

migrate to fastnear #355

merged 4 commits into from
Oct 3, 2024

Conversation

kobayurii
Copy link
Member

@kobayurii kobayurii commented Oct 2, 2024

This PR brings significant improvements to the read_rpc server after adding fastnear as an alternative data provider for NEAR Lake (near/near-lake-framework-rs#109).

Improvements to read_rpc Server:

  • Leveraged the introduction of fastnear to optimize the read_rpc server.
  • Simplified data processing logic of final and optimistic blocks, reducing latency and increasing throughput.
  • Improved system to fetch blocks and chunks to enhance reliability and robustness, particularly in high-load scenarios.

These enhancements contribute to better overall performance of the read_rpc server, resulting in higher reliability, faster response times, and a more resilient system.

@kobayurii
Copy link
Member Author

@race-of-sloths please, include my PR in the Race

@kobayurii kobayurii marked this pull request as ready for review October 3, 2024 08:34
Copy link
Member

@khorolets khorolets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, I've highlighted a few places to note. However, nothing critical so far, so we're good to merge even without addressing the things I've mentioned in the PR review. Great job!

configuration/example.config.toml Outdated Show resolved Hide resolved
@@ -20,8 +20,7 @@ pub struct GenesisInfo {
impl GenesisInfo {
pub async fn get(
near_rpc_client: &crate::utils::JsonRpcClient,
s3_client: &near_lake_framework::s3_fetchers::LakeS3Client,
s3_bucket_name: &str,
fastnear_client: &near_lake_framework::fastnear_client::FastNearClient,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change basically indicates disadvantages we are about to introduce to the near-lake-framework. I would expect near_lake_framework::Client here that could work with either Lake data or FastNear data. We need to rethink the changes on the framework. Though, it is not a blocker for this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will improve it on the near-lake-framework side.

rpc-server/src/utils.rs Show resolved Hide resolved
rpc-server/src/utils.rs Outdated Show resolved Hide resolved
@kobayurii kobayurii merged commit ec9bed7 into database-new Oct 3, 2024
3 checks passed
kobayurii added a commit that referenced this pull request Oct 4, 2024
kobayurii added a commit that referenced this pull request Oct 4, 2024
@race-of-sloths-bot
Copy link

race-of-sloths-bot commented Oct 4, 2024

@kobayurii Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Do you want to apply for monthly streak? Get 8+ score for a single PR this month and receive boost for race-of-sloths!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@race-of-sloths 2

Your contribution is much appreciated with a final score of 2!
You have received 21 (20 base + 5% lifetime bonus) Sloth points for this contribution

We would appreciate your feedback or contribution idea that you can submit here

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@frol
Copy link
Collaborator

frol commented Oct 4, 2024

Hey, unfortunately, we skipped this PR as our bot was blocked :( But we extended the time range so should pass just now. Sorry for the inconvenience.

@race-of-sloths include

@race-of-sloths-bot
Copy link

🥁 Score it!

@khorolets, please score the PR with @race-of-sloths score [1/2/3/5/8/13]. The contributor deserves it.
If no scoring is provided within 24 hours, this PR will be scored as 2 🦥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants