Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query parameters to create-app page for pre-filling form #488

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

nenb
Copy link
Contributor

@nenb nenb commented Sep 23, 2024

Reference Issues or PRs

Issue: #472

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 6:36pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 6:36pm

Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good, but might be able to simplify your implementation as mentioned in the comment.

Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing...see the comment

@jbouder
Copy link
Collaborator

jbouder commented Sep 30, 2024

PR looks good now. Just need to resolve the merge conflict on the build. To do that, you’ll need to do a few things:

  1. Merge main into your branch (make sure to do a fresh pull on main)
  2. Delete the local index.js to resolve any merge conflicts on that file
  3. Perform an ‘npm install’ from the ui directory
  4. Perform an ‘npm run build’ from the ui directory
  5. Commit the new build and push

@nenb
Copy link
Contributor Author

nenb commented Sep 30, 2024

PR looks good now. Just need to resolve the merge conflict on the build. To do that, you’ll need to do a few things:

Ah, sorry, I was halfway through a rebase before I saw this. I think it should be okay now.

Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jbouder jbouder merged commit 30fcc5d into nebari-dev:main Sep 30, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants