Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse the "create empty" section on test snapshot #12

Merged
merged 5 commits into from
May 7, 2024
Merged

Collapse the "create empty" section on test snapshot #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
79d3d47
Collapse the "create empty" section on test snapshot
krassowski May 7, 2024
fbee201
Update snapshot
krassowski May 7, 2024
35a94de
Fix the test path
krassowski May 7, 2024
3d0b0ee
Wait for animations
krassowski May 7, 2024
448beb4
Update snapshot
krassowski May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ui-tests/tests/jupyterlab_new_launcher.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ test.describe('With starred section', () => {
.locator('.jp-Launcher-launchNotebook .jp-starIconButton')
.click();
await page.locator('.jp-Launcher-launchConsole .jp-starIconButton').click();
// collapse the "create empty" section
await page.locator('.jp-Launcher-openByType summary').click();
// wait for animations to complete
await page.waitForTimeout(400);
expect(await launcher.screenshot()).toMatchSnapshot(
'launcher-with-starred.png'
);
Expand Down
Binary file modified ...tests/jupyterlab_new_launcher.spec.ts-snapshots/launcher-with-starred-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading