add pip check [failing tests show why this PR is needed] #197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
Resolves #173 by adding pip check for every conda env. I couldn't simple run pip check on the ENV_NAME b/c it's not accurate in the case of NEW_ENV=false (existing environment update). Our images have at most 2 environments currently so running pip check twice doesn't add much time to the build.
Note: The current docker images do not satisfy pip check currently. See the logs from the jupyterlab-cpu image below for example.
I believe the issue with simpervisor is that jh-single-native used by jhub-apps is unmaintained and requires
simpervisor~=0.4
. From the simpervisor changelog they don't list any breaking changes so it may be easy to fix by changing the simpervisor requirement to simpervisor >=0.4 in jh-single-native. I know @aktech has mentioned not wanting to depend on jh-single-native anymore for jhub-apps.What does this implement/fix?
Put a
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?