Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pip check [failing tests show why this PR is needed] #197

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Feb 19, 2025

Reference Issues or PRs

Resolves #173 by adding pip check for every conda env. I couldn't simple run pip check on the ENV_NAME b/c it's not accurate in the case of NEW_ENV=false (existing environment update). Our images have at most 2 environments currently so running pip check twice doesn't add much time to the build.

Note: The current docker images do not satisfy pip check currently. See the logs from the jupyterlab-cpu image below for example.

#27 167.8 Checking dependencies for environment: default
#27 167.8 + echo 'Checking dependencies for environment: default'
#27 167.8 + mamba run --live-stream -n default python -m pip check
#27 169.2 jupyter-ai 2.29.1 requires faiss-cpu, which is not installed.
#27 169.2 jupyter-server-proxy 4.4.0 has requirement simpervisor>=1.0.0, but you have simpervisor 0.4.

I believe the issue with simpervisor is that jh-single-native used by jhub-apps is unmaintained and requires simpervisor~=0.4. From the simpervisor changelog they don't list any breaking changes so it may be easy to fix by changing the simpervisor requirement to simpervisor >=0.4 in jh-single-native. I know @aktech has mentioned not wanting to depend on jh-single-native anymore for jhub-apps.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@Adam-D-Lewis Adam-D-Lewis linked an issue Feb 19, 2025 that may be closed by this pull request
@Adam-D-Lewis Adam-D-Lewis changed the title add pip check add pip check [failing tests show why this PR is needed] Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - pip installs overwrite and break conda environments
1 participant