Implement hash functions #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
twitu
approved these changes
Sep 26, 2020
Closed
|
Implement enums for hash functions and hash function chooser that returns the corresponding function for an enum. This way the hash table can be configured by the user to use different kinds of hash functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the issue addressed in this PR? (include repro steps if any)
This PR implements hashing functions to be used in the hashtable.
Github issue
Closing #2
What was the cause of the issue?
NA
What steps have been implemented?
What is the impact radius?
Testing
Have you written UTs? Describe test cases
Have you written E2Es? Describe test cases
What was the UT code coverage?