Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create hashtable #8

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Create hashtable #8

wants to merge 6 commits into from

Conversation

twitu
Copy link
Collaborator

@twitu twitu commented Sep 12, 2020

Description

What is the issue addressed in this PR? (include repro steps if any)
This PR creates the hashtable that uses linkedlist and hashing package to create an structure for storing values.

Github issue
Closing #4

What was the cause of the issue?
NA

What steps have been implemented?

  • Create, Get, Insert, Delete have been implemented
  • Keys and value are being converted to byte arrays before being passed to LinkedList

What is the impact radius?
NA

Testing

Have you written UTs? Describe test cases
NA

Have you written E2Es? Describe test cases

What was the UT code coverage?

  • Link the relevant issue
  • Code coverage above 90%
  • Resolve all comments, 2-reviewer sign-off

@twitu
Copy link
Collaborator Author

twitu commented Sep 12, 2020

TODOs

  • Implement resize and shrink functions
  • Decide on threshold for resizing and shrinking
  • write test cases for CRUD and E2E tests

@twitu twitu linked an issue Sep 12, 2020 that may be closed by this pull request
pkg/helper/hasher.go Outdated Show resolved Hide resolved
pkg/hashtable/hashtable.go Show resolved Hide resolved
pkg/hashtable/hashtable.go Outdated Show resolved Hide resolved
Add test function stubs
Use uint64 across all attributes
Add comments and test case fail messages
@twitu twitu marked this pull request as draft September 29, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hash Array
2 participants