Don't fail the workflow when failed to emit metrics for one domain in…

… ES analyzer
neil-xie · Jan 23, 2025 · bc6c923 · bc6c923
1 parent 61caf40
commit bc6c923
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/service/worker/esanalyzer/domainWorkflowTypeCountWorkflow.go b/service/worker/esanalyzer/domainWorkflowTypeCountWorkflow.go
@@ -158,7 +158,7 @@ func (w *Workflow) emitWorkflowTypeCountMetrics(ctx context.Context) error {
 				err = w.emitWorkflowTypeCountMetricsES(ctx, domainName, logger)
 			}
 			if err != nil {
-				return err
+				logger.Error(fmt.Sprintf("Failed to emit workflow type metrics for domain %s", domainName), zap.Error(err))
 			}
 		}
 	}

diff --git a/service/worker/esanalyzer/workflow.go b/service/worker/esanalyzer/workflow.go
@@ -207,7 +207,7 @@ func (w *Workflow) emitWorkflowVersionMetrics(ctx context.Context) error {
 				err = w.emitWorkflowVersionMetricsES(ctx, domainName, logger)
 			}
 			if err != nil {
-				return err
+				logger.Error(fmt.Sprintf("Failed to emit workflow version metrics for domain %s", domainName), zap.Error(err))
 			}
 		}
 	}