Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run yarn build when starting up frontend container #1021

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kagesenshi
Copy link

@kagesenshi kagesenshi commented Jan 23, 2025

Problem statement

frontend docker container at the moment set conf iguration (VITE_* etc) during container build time, which means secrets (API keys etc) and configs are stored in the container image, and configuration could not be changed during docker run. This makes the workflow of uploading container image to container registry prior to deployment to not work properly.

This pull request is a suggestion on modifying frontend Dockerfile to run yarn build when container is starting up so that config are applied during container start.

I'm primarily Python+Linux programmer and not quite a frontend person and has low familiarity with yarn build and how it update config files, not sure if this is the right way to do it, but putting this request here for comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant