Run yarn build when starting up frontend container #1021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
frontend docker container at the moment set conf iguration (
VITE_*
etc) during container build time, which means secrets (API keys etc) and configs are stored in the container image, and configuration could not be changed duringdocker run
. This makes the workflow of uploading container image to container registry prior to deployment to not work properly.This pull request is a suggestion on modifying frontend Dockerfile to run
yarn build
when container is starting up so that config are applied during container start.I'm primarily Python+Linux programmer and not quite a frontend person and has low familiarity with
yarn build
and how it update config files, not sure if this is the right way to do it, but putting this request here for comment.