Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Cypher version #1123

Open
wants to merge 21 commits into
base: cypher-25
Choose a base branch
from

Conversation

JPryce-Aklundh
Copy link
Collaborator

@JPryce-Aklundh JPryce-Aklundh commented Nov 27, 2024

Operations manual PRs mentioned in this PR:

TODO: Add clarifying note on Additions page

Copy link
Collaborator

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be a surprise that I have several comments XD

@JPryce-Aklundh JPryce-Aklundh marked this pull request as ready for review February 25, 2025 14:23
.Create a database with Cypher 5 as the default language
[source, cypher]
----
CREATE DATABASE my_database DEFAULT LANGUAGE CYPHER 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have linked back to these sections from the operations manual documentation of these commands. There doesn't seem much point documenting it twice.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all sections related to database administration should go to the Operations manual, and here, we can add just one link.

@neo-technology-commit-status-publisher
Copy link
Collaborator

This PR includes documentation updates
View the updated docs at https://neo4j-docs-cypher-1123.surge.sh

New pages:

Updated pages:

Comment on lines +236 to +237
*Existing user databases:* `CYPHER 5` +
*New user databases default:* `CYPHER 5`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add something like this for the remote alias case I mentioned on slack (in addition to having a short sentence about it somewhere as we discussed)

Suggested change
*Existing user databases:* `CYPHER 5` +
*New user databases default:* `CYPHER 5`
*Existing user databases:* `CYPHER 5` +
*Existing non-constituent remote database aliases:* `CYPHER 5` +
*New user databases and non-constituent remote database aliases default:* `CYPHER 5`

(if yes, then we should also update the other two rows in the table)

@recrwplay
Copy link
Contributor

This PR includes documentation updates
View the updated docs at https://neo4j-docs-cypher-1123.surge.sh

New pages:

Updated pages:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants