Skip to content

Commit

Permalink
Merge pull request #1182 from OskarDamkjaer/cypress_video_quality
Browse files Browse the repository at this point in the history
Don't animate on first render and compress less
  • Loading branch information
OskarDamkjaer authored Sep 2, 2020
2 parents 5a96127 + 6692522 commit 7d22299
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
6 changes: 3 additions & 3 deletions cypress.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"animationDistanceThreshold": 5,
"animationDistanceThreshold": 1,
"baseUrl": "http://localhost:8080",
"chromeWebSecurity": false,
"defaultCommandTimeout": 10000,
Expand All @@ -9,7 +9,7 @@
"fixturesFolder": "e2e_tests/fixtures",
"hosts": null,
"integrationFolder": "e2e_tests/integration",
"numTestsKeptInMemory": 50,
"numTestsKeptInMemory": 1,
"pageLoadTimeout": 60000,
"pluginsFile": "e2e_tests/plugins/index.js",
"port": null,
Expand All @@ -20,7 +20,7 @@
"screenshotsFolder": "e2e_tests/screenshots",
"supportFile": "e2e_tests/support",
"trashAssetsBeforeRuns": true,
"videoCompression": 32,
"videoCompression": false,
"video": true,
"videosFolder": "e2e_tests/videos",
"videoUploadOnPasses": false,
Expand Down
5 changes: 2 additions & 3 deletions src/browser/modules/Editor/EditorFrame.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export function EditorFrame({ bus }: EditorFrameProps): JSX.Element {

setAnimation({
from: stable,
// @ts-expect-error, library typing are wrong....
// @ts-expect-error, library typings are wrong....
to: [end, start, stable],
config
})
Expand Down Expand Up @@ -158,7 +158,6 @@ export function EditorFrame({ bus }: EditorFrameProps): JSX.Element {

const TypedEditor: any = Editor // delete this when editor is ts
const [props, setAnimation] = useSpring(() => ({
from: start,
to: stable,
config
}))
Expand All @@ -168,7 +167,7 @@ export function EditorFrame({ bus }: EditorFrameProps): JSX.Element {
<animated.div
className="springContainer"
style={props}
data-testid={'activeEditor'}
data-testid="activeEditor"
>
<Frame fullscreen={isFullscreen}>
<FrameHeader>
Expand Down

0 comments on commit 7d22299

Please sign in to comment.