fixed notification step (#492)

neonlabsorg · Jan 23, 2025 · 77e8a9b · 77e8a9b
1 parent 4ba7d0b
commit 77e8a9b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 9 deletions.
diff --git a/.github/workflows/basic.yml b/.github/workflows/basic.yml
@@ -281,15 +281,17 @@ jobs:
           ci_stands_key_hcloud: ${{ secrets.CI_STANDS_KEY_HCLOUD }}
   send-notification:
     name: Send notification on failure
+    if: failure() && github.ref_name == 'develop'
     needs:
       - run-proxy-tests
       - run-evm-tests
     runs-on: ["self-hosted", "k8s-prod"]
     steps:
       - uses: actions/checkout@v4
-      - name: "Notify on failure."
-        if: failure() && github.ref_name == 'develop'
+      - name: Install python requirements
+        id: requirements
+        uses: ./.github/actions/python-requirements
+      - name: Notify on failure
         run: |
-          docker exec -i ${{ env.CONTAINER }} \
-            python3 ./clickfile.py send-notification -u ${{ secrets.SLACK_QA_CHANNEL_URL }} \
+          python3 ./clickfile.py send-notification -u ${{ secrets.SLACK_QA_CHANNEL_URL }} \
           -b ${{ env.BUILD_URL }} --network ${{ env.NETWORK }} --test-group ${{ env.FAILED_TEST_GROUP }}
diff --git a/.github/workflows/ui.yml b/.github/workflows/ui.yml
@@ -74,15 +74,19 @@ jobs:
           aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
           tests_name: ui
 
+      - name: Remove docker container
+        if: always()
+        run: docker rm -f ${{ env.CONTAINER_NAME }}
   notify:
     name: Send notification on failure
     needs: test
     if: failure() && github.ref_name == 'develop'
-    runs-on: ubuntu-latest
+    runs-on: ["self-hosted", "k8s-prod"]
     steps:
       - uses: actions/checkout@v4
-      - name: "Notify on failure"
+      - name: Install python requirements
+        uses: ./.github/actions/python-requirements
+      - name: Notify on failure
         run: |
-          docker exec -i ${{ env.CONTAINER_NAME }} \
-            python3 ./clickfile.py send-notification -u ${{ secrets.SLACK_QA_CHANNEL_URL }} \
-            -b ${{ env.BUILD_URL }} --network ${{ env.NETWORK }} --test-group ui
+          python3 ./clickfile.py send-notification -u ${{ secrets.SLACK_QA_CHANNEL_URL }} \
+          -b ${{ env.BUILD_URL }} --network ${{ env.NETWORK }} --test-group ui