updated eip-1559 tests #520
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # integration/tests/conftest.py
# Conflicts: # conftest.py # integration/tests/conftest.py
|
|
||
| if environment.name in prod_envs or environment.use_bank: | ||
| lamports = 2 * LAMPORT_PER_SOL | ||
| evm_loader.send_sol(bank_account, user.solana_account.pubkey(), lamports) |
There was a problem hiding this comment.
environment.use_bank condition is enough
lamports value for if and else can be the same and "if balance < lamports" is more actual forcase if we use environment.use_bank because in this case we don't create a new user
| @@ -146,9 +146,7 @@ def validate_transfer_positive( | |||
| ) | |||
|
|
|||
| # Verify that the effective gas price does not exceed the max fee per gas | |||
There was a problem hiding this comment.
looks like you need to change comments like this as well
| @@ -116,6 +116,7 @@ def test_scheduled_trx_wrong_index( | |||
| with pytest.raises(solana.rpc.core.RPCException, match=InstructionAsserts.TRANSACTION_TREE_INVALID_DATA): | |||
| evm_loader.create_tree_account(neon_user, treasury_pool, tx.encode(), environment.sol_mint_id) | |||
|
|
|||
| @pytest.mark.eip_1559 | |||
There was a problem hiding this comment.
please remove eip_1559 marks from scheduled transactions tests
there are different type of transactions
| @@ -308,6 +309,7 @@ def make_raw_tx_eip_1559( | |||
| gas: tp.Union[int, tp.Literal["auto"], None], | |||
| max_priority_fee_per_gas: tp.Union[int, tp.Literal["auto"], None], | |||
| max_fee_per_gas: tp.Union[int, tp.Literal["auto"], None], | |||
| base_fee_per_gas: tp.Union[int, tp.Literal["auto"]] = "auto", | |||
There was a problem hiding this comment.
seams you don't use it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.