review and refactor according to github security scans

Signed-off-by: neo <1100909+neowu@users.noreply.github.com>
neowu · Nov 8, 2024 · b6e0a1b · b6e0a1b
1 parent 47876cc
commit b6e0a1b
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 23 deletions.
diff --git a/core-ng/src/main/java/core/framework/http/EventSource.java b/core-ng/src/main/java/core/framework/http/EventSource.java
@@ -15,7 +15,7 @@
 /**
  * @author neo
  */
-public final class EventSource implements AutoCloseable, Iterable<EventSource.Event>, Iterator<EventSource.Event> {
+public final class EventSource implements AutoCloseable, Iterable<EventSource.Event> {
     private static final Logger LOGGER = LoggerFactory.getLogger(EventSource.class);
     public final int statusCode;
     public final Map<String, String> headers;   // headers key is case insensitive
@@ -43,27 +43,27 @@ public void close() {
         body.close();
     }
 
-    @Override
-    public boolean hasNext() {
-        if (nextEvent != null) return true;
-        nextEvent = parseResponse(body.source());
-        return nextEvent != null;
-    }
-
-    @Override
-    public Event next() {
-        if (nextEvent != null || hasNext()) {
-            var event = nextEvent;
-            nextEvent = null;
-            return event;
-        } else {
-            throw new NoSuchElementException();
-        }
-    }
-
     @Override
     public Iterator<Event> iterator() {
-        return this;
+        return new Iterator<>() {
+            @Override
+            public boolean hasNext() {
+                if (nextEvent != null) return true;
+                nextEvent = parseResponse(body.source());
+                return nextEvent != null;
+            }
+
+            @Override
+            public Event next() {
+                if (nextEvent != null || hasNext()) {
+                    var event = nextEvent;
+                    nextEvent = null;
+                    return event;
+                } else {
+                    throw new NoSuchElementException();
+                }
+            }
+        };
     }
 
     private Event parseResponse(BufferedSource source) {

diff --git a/core-ng/src/main/java/core/framework/util/Files.java b/core-ng/src/main/java/core/framework/util/Files.java
@@ -36,7 +36,7 @@ public static byte[] bytes(Path file) {
         } catch (IOException e) {
             throw new UncheckedIOException(e);
         } finally {
-            LOGGER.debug("bytes, file={}, elapsed={}", file, watch.elapsed());
+            LOGGER.debug("bytes, file={}, elapsed={}", file.toString(), watch.elapsed());
         }
     }
 
@@ -73,12 +73,12 @@ public FileVisitResult postVisitDirectory(Path dir, IOException e) {
 
     public static Path tempFile() {
         String tempDir = System.getProperty("java.io.tmpdir");
-        return Paths.get(tempDir + "/" + UUID.randomUUID().toString() + ".tmp");
+        return Paths.get(tempDir + "/" + UUID.randomUUID() + ".tmp");
     }
 
     public static Path tempDir() {
         String tempDir = System.getProperty("java.io.tmpdir");
-        Path path = Paths.get(tempDir + "/" + UUID.randomUUID().toString());
+        Path path = Paths.get(tempDir + "/" + UUID.randomUUID());
         createDir(path);
         return path;
     }