* log-exporter: replace "rm -rf" with "find -delete"

Signed-off-by: neo <1100909+neowu@users.noreply.github.com>
neowu · Nov 1, 2024 · c3467fc · c3467fc
1 parent 4530f97
commit c3467fc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,8 @@
 * http_client: use 1 hour TTL for fallback dns cache
   > report error for permanent DNS issue after 1 hour
 * jre: published neowu/jre:21.0.5
+* log-exporter: replace "rm -rf" with "find -delete"
+  > "find" is more memory efficient, "rm -rf" may cause OOM with deep dir and many files
 
 ### 9.1.3 (9/26/2024 - 10/17/2024)
 

diff --git a/ext/log-exporter/src/main/java/core/log/service/ArchiveService.java b/ext/log-exporter/src/main/java/core/log/service/ArchiveService.java
@@ -59,8 +59,9 @@ public void cleanupArchive(LocalDate date) {
         Path eventFilePath = Path.of(logDir.toString(), eventPath(date));
         shell.execute("rm", "-f", eventFilePath.toString());
 
-        Path traceLogDirPath = Path.of(logDir.toString(), Strings.format("/trace/{}", date));
-        shell.execute("rm", "-rf", traceLogDirPath.toString());
+        String traceLogDirPath = Path.of(logDir.toString(), Strings.format("/trace/{}", date)).toString();
+        shell.execute("find", traceLogDirPath, "-type", "f", "-delete");
+        shell.execute("find", traceLogDirPath, "-type", "d", "-delete");
     }
 
     public String actionLogPath(LocalDate date) {