Skip to content

[manageemnt] port forwarding add peer manager fix network map #8133

[manageemnt] port forwarding add peer manager fix network map

[manageemnt] port forwarding add peer manager fix network map #8133

Triggered via pull request February 1, 2025 00:16
Status Failure
Total duration 11m 34s
Artifacts

golangci-lint.yml

on: pull_request
codespell
11s
codespell
Matrix: lint
Fit to window
Zoom out
Zoom in

Annotations

29 errors
lint (macos-latest): management/server/http/testing/testing_tools/tools.go#L113
not enough arguments in call to server.BuildManager
lint (macos-latest): management/server/http/testing/testing_tools/tools.go#L122
not enough arguments in call to nbhttp.NewAPIHandler
lint (macos-latest): client/cmd/testutil_test.go#L92
not enough arguments in call to mgmt.BuildManager
lint (macos-latest): client/internal/engine_test.go#L1223
not enough arguments in call to server.BuildManager
lint (macos-latest): client/server/server_test.go#L131
not enough arguments in call to server.BuildManager
lint (macos-latest): management/client/client_test.go#L75
not enough arguments in call to mgmt.BuildManager
lint (macos-latest): management/server/account_test.go#L2903
not enough arguments in call to BuildManager
lint (macos-latest): management/server/dns_test.go#L211
not enough arguments in call to BuildManager
lint (macos-latest): management/server/management_proto_test.go#L433
not enough arguments in call to BuildManager
lint (macos-latest): management/server/nameserver_test.go#L773
not enough arguments in call to BuildManager
lint (ubuntu-latest): management/server/http/testing/testing_tools/tools.go#L113
not enough arguments in call to server.BuildManager
lint (ubuntu-latest): management/server/http/testing/testing_tools/tools.go#L122
not enough arguments in call to nbhttp.NewAPIHandler
lint (ubuntu-latest): client/cmd/testutil_test.go#L92
not enough arguments in call to mgmt.BuildManager
lint (ubuntu-latest): client/internal/engine_test.go#L1223
not enough arguments in call to server.BuildManager
lint (ubuntu-latest): client/server/server_test.go#L131
not enough arguments in call to server.BuildManager
lint (ubuntu-latest): management/client/client_test.go#L75
not enough arguments in call to mgmt.BuildManager
lint (ubuntu-latest): management/server/account_test.go#L2903
not enough arguments in call to BuildManager
lint (ubuntu-latest): management/server/dns_test.go#L211
not enough arguments in call to BuildManager
lint (ubuntu-latest): management/server/management_proto_test.go#L433
not enough arguments in call to BuildManager
lint (ubuntu-latest): management/server/nameserver_test.go#L773
not enough arguments in call to BuildManager
lint (windows-latest): management/server/peers/manager.go#L23
type `managerMock` is unused (unused)
lint (windows-latest)
not enough arguments in call to nbhttp.NewAPIHandler\n\thave (\"context\".Context, *server.DefaultAccountManager, \"github.com/netbirdio/netbird/management/server/networks\".Manager, resources.Manager, routers.Manager, \"github.com/netbirdio/netbird/management/server/groups\".Manager, *geolocation.Mock, *jwtclaims.JwtValidatorMock, telemetry.AppMetrics, configs.AuthCfg, server.MocIntegratedValidator)\n\twant (\"context\".Context, server.AccountManager, \"github.com/netbirdio/netbird/management/server/networks\".Manager, resources.Manager, routers.Manager, \"github.com/netbirdio/netbird/management/server/groups\".Manager, geolocation.Geolocation, jwtclaims.JWTValidator, telemetry.AppMetrics, configs.AuthCfg, integrated_validator.IntegratedValidator, port_forwarding.Controller, permissions.Manager, \"github.com/netbirdio/netbird/management/server/peers\".Manager)"
lint (windows-latest)
not enough arguments in call to mgmt.BuildManager\n\thave (\"context\".Context, \"github.com/netbirdio/netbird/management/server/store\".Store, *\"github.com/netbirdio/netbird/management/server\".PeersUpdateManager, nil, string, string, *activity.InMemoryEventStore, nil, bool, *integrations.IntegratedValidatorImpl, telemetry.AppMetrics)\n\twant (\"context\".Context, \"github.com/netbirdio/netbird/management/server/store\".Store, *\"github.com/netbirdio/netbird/management/server\".PeersUpdateManager, idp.Manager, string, string, activity.Store, geolocation.Geolocation, bool, integrated_validator.IntegratedValidator, telemetry.AppMetrics, port_forwarding.Controller)"
lint (windows-latest)
not enough arguments in call to server.BuildManager\n\thave (\"context\".Context, \"github.com/netbirdio/netbird/management/server/store\".Store, *\"github.com/netbirdio/netbird/management/server\".PeersUpdateManager, nil, string, string, *activity.InMemoryEventStore, nil, bool, *integrations.IntegratedValidatorImpl, telemetry.AppMetrics)\n\twant (\"context\".Context, \"github.com/netbirdio/netbird/management/server/store\".Store, *\"github.com/netbirdio/netbird/management/server\".PeersUpdateManager, idp.Manager, string, string, activity.Store, geolocation.Geolocation, bool, integrated_validator.IntegratedValidator, telemetry.AppMetrics, port_forwarding.Controller)"
lint (windows-latest)
not enough arguments in call to server.BuildManager\n\thave (\"context\".Context, \"github.com/netbirdio/netbird/management/server/store\".Store, *\"github.com/netbirdio/netbird/management/server\".PeersUpdateManager, nil, string, string, *activity.InMemoryEventStore, nil, bool, *integrations.IntegratedValidatorImpl, telemetry.AppMetrics)\n\twant (\"context\".Context, \"github.com/netbirdio/netbird/management/server/store\".Store, *\"github.com/netbirdio/netbird/management/server\".PeersUpdateManager, idp.Manager, string, string, activity.Store, geolocation.Geolocation, bool, integrated_validator.IntegratedValidator, telemetry.AppMetrics, port_forwarding.Controller)"
lint (windows-latest)
not enough arguments in call to mgmt.BuildManager\n\thave (\"context\".Context, \"github.com/netbirdio/netbird/management/server/store\".Store, *server.PeersUpdateManager, nil, string, string, *activity.InMemoryEventStore, nil, bool, *integrations.IntegratedValidatorImpl, telemetry.AppMetrics)\n\twant (\"context\".Context, \"github.com/netbirdio/netbird/management/server/store\".Store, *server.PeersUpdateManager, idp.Manager, string, string, activity.Store, geolocation.Geolocation, bool, integrated_validator.IntegratedValidator, telemetry.AppMetrics, port_forwarding.Controller)"
lint (windows-latest)
not enough arguments in call to BuildManager\n\thave (\"context\".Context, \"github.com/netbirdio/netbird/management/server/store\".Store, *PeersUpdateManager, nil, string, string, *activity.InMemoryEventStore, nil, bool, MocIntegratedValidator, telemetry.AppMetrics)\n\twant (\"context\".Context, \"github.com/netbirdio/netbird/management/server/store\".Store, *PeersUpdateManager, idp.Manager, string, string, activity.Store, geolocation.Geolocation, bool, integrated_validator.IntegratedValidator, telemetry.AppMetrics, port_forwarding.Controller)"
lint (windows-latest)
not enough arguments in call to BuildManager\n\thave (\"context\".Context, \"github.com/netbirdio/netbird/management/server/store\".Store, *PeersUpdateManager, nil, string, string, *activity.InMemoryEventStore, nil, bool, MocIntegratedValidator, telemetry.AppMetrics)\n\twant (\"context\".Context, \"github.com/netbirdio/netbird/management/server/store\".Store, *PeersUpdateManager, idp.Manager, string, string, activity.Store, geolocation.Geolocation, bool, integrated_validator.IntegratedValidator, telemetry.AppMetrics, port_forwarding.Controller))"
lint (windows-latest)
issues found