Skip to content

Commit

Permalink
export more consts in test
Browse files Browse the repository at this point in the history
  • Loading branch information
@pascal-fischer
pascal-fischer committed Dec 30, 2024
1 parent 3698eb9 commit 6fe4529
Showing 1 changed file with 31 additions and 27 deletions.
58 changes: 31 additions & 27 deletions management/server/types/account_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -381,9 +381,13 @@ func Test_AddNetworksRoutingPeersHandlesNoMissingPeers(t *testing.T) {
}

const (
accID = "accountID"
network1ID = "network1ID"
group1ID = "group1"
accNetResourcePeer1ID = "peer1"
accNetResourcePeer2ID = "peer2"
accNetResourceRouter1ID = "router1"
accNetResource1ID = "resource1ID"
accNetResourceRestrictPostureCheckID = "restrictPostureCheck"
accNetResourceRelaxedPostureCheckID = "relaxedPostureCheck"
accNetResourceLockedPostureCheckID = "lockedPostureCheck"
Expand All @@ -399,11 +403,11 @@ var (

func getBasicAccountsWithResource() *Account {
return &Account{
Id: "accountID",
Id: accID,
Peers: map[string]*nbpeer.Peer{
accNetResourcePeer1ID: {
ID: accNetResourcePeer1ID,
AccountID: "accountID",
AccountID: accID,
Key: "peer1Key",
IP: accNetResourcePeer1IP,
Meta: nbpeer.PeerSystemMeta{
Expand All @@ -414,7 +418,7 @@ func getBasicAccountsWithResource() *Account {
},
accNetResourcePeer2ID: {
ID: accNetResourcePeer2ID,
AccountID: "accountID",
AccountID: accID,
Key: "peer2Key",
IP: accNetResourcePeer2IP,
Meta: nbpeer.PeerSystemMeta{
Expand All @@ -425,8 +429,8 @@ func getBasicAccountsWithResource() *Account {
},
accNetResourceRouter1ID: {
ID: accNetResourceRouter1ID,
AccountID: "accountID",
Key: "peer2Key",
AccountID: accID,
Key: "router1Key",
IP: accNetResourceRouter1IP,
Meta: nbpeer.PeerSystemMeta{
GoOS: "linux",
Expand All @@ -436,34 +440,34 @@ func getBasicAccountsWithResource() *Account {
},
},
Groups: map[string]*Group{
"group1": {
ID: "group1",
group1ID: {
ID: group1ID,
Peers: []string{accNetResourcePeer1ID, accNetResourcePeer2ID},
},
},
Networks: []*networkTypes.Network{
{
ID: "network1ID",
AccountID: "accountID",
ID: network1ID,
AccountID: accID,
Name: "network1",
},
},
NetworkRouters: []*routerTypes.NetworkRouter{
{
ID: "router1ID",
NetworkID: "network1ID",
AccountID: "accountID",
Peer: "router1",
ID: accNetResourceRouter1ID,
NetworkID: network1ID,
AccountID: accID,
Peer: accNetResourceRouter1ID,
PeerGroups: []string{},
Masquerade: false,
Metric: 100,
},
},
NetworkResources: []*resourceTypes.NetworkResource{
{
ID: "resource1ID",
AccountID: "accountID",
NetworkID: "network1ID",
ID: accNetResource1ID,
AccountID: accID,
NetworkID: network1ID,
Address: "10.10.10.0/24",
Prefix: netip.MustParsePrefix("10.10.10.0/24"),
Type: resourceTypes.NetworkResourceType("subnet"),
Expand All @@ -472,15 +476,15 @@ func getBasicAccountsWithResource() *Account {
Policies: []*Policy{
{
ID: "policy1ID",
AccountID: "accountID",
AccountID: accID,
Enabled: true,
Rules: []*PolicyRule{
{
ID: "rule1ID",
Enabled: true,
Sources: []string{"group1"},
Sources: []string{group1ID},
DestinationResource: Resource{
ID: "resource1ID",
ID: accNetResource1ID,
Type: "Host",
},
Protocol: PolicyRuleProtocolTCP,
Expand Down Expand Up @@ -551,7 +555,7 @@ func Test_NetworksNetMapGenWithNoPostureChecks(t *testing.T) {
assert.Len(t, sourcePeers, 0, "expected source peers don't match")

isRouter, networkResourcesRoutes, sourcePeers = account.GetNetworkResourcesRoutesToSync(context.Background(), accNetResourceRouter1ID, account.GetResourcePoliciesMap(), account.GetResourceRoutersMap())
rules := account.GetPeerNetworkResourceFirewallRules(context.Background(), account.Peers["router1"], accNetResourceValidPeers, networkResourcesRoutes, account.GetResourcePoliciesMap())
rules := account.GetPeerNetworkResourceFirewallRules(context.Background(), account.Peers[accNetResourceRouter1ID], accNetResourceValidPeers, networkResourcesRoutes, account.GetResourcePoliciesMap())
assert.True(t, isRouter, "should be router")
assert.Len(t, networkResourcesRoutes, 1, "expected network resource route don't match")
assert.Len(t, sourcePeers, 2, "expected source peers don't match")
Expand Down Expand Up @@ -586,7 +590,7 @@ func Test_NetworksNetMapGenWithPostureChecks(t *testing.T) {
assert.Len(t, sourcePeers, 0, "expected source peers don't match")

isRouter, networkResourcesRoutes, sourcePeers = account.GetNetworkResourcesRoutesToSync(context.Background(), accNetResourceRouter1ID, account.GetResourcePoliciesMap(), account.GetResourceRoutersMap())
rules := account.GetPeerNetworkResourceFirewallRules(context.Background(), account.Peers["router1"], accNetResourceValidPeers, networkResourcesRoutes, account.GetResourcePoliciesMap())
rules := account.GetPeerNetworkResourceFirewallRules(context.Background(), account.Peers[accNetResourceRouter1ID], accNetResourceValidPeers, networkResourcesRoutes, account.GetResourcePoliciesMap())
assert.True(t, isRouter, "should be router")
assert.Len(t, networkResourcesRoutes, 1, "expected network resource route don't match")
assert.Len(t, sourcePeers, 1, "expected source peers don't match")
Expand Down Expand Up @@ -621,7 +625,7 @@ func Test_NetworksNetMapGenWithNoMatchedPostureChecks(t *testing.T) {
assert.Len(t, sourcePeers, 0, "expected source peers don't match")

isRouter, networkResourcesRoutes, sourcePeers = account.GetNetworkResourcesRoutesToSync(context.Background(), accNetResourceRouter1ID, account.GetResourcePoliciesMap(), account.GetResourceRoutersMap())
rules := account.GetPeerNetworkResourceFirewallRules(context.Background(), account.Peers["router1"], accNetResourceValidPeers, networkResourcesRoutes, account.GetResourcePoliciesMap())
rules := account.GetPeerNetworkResourceFirewallRules(context.Background(), account.Peers[accNetResourceRouter1ID], accNetResourceValidPeers, networkResourcesRoutes, account.GetResourcePoliciesMap())
assert.True(t, isRouter, "should be router")
assert.Len(t, networkResourcesRoutes, 1, "expected network resource route don't match")
assert.Len(t, sourcePeers, 0, "expected source peers don't match")
Expand All @@ -638,15 +642,15 @@ func Test_NetworksNetMapGenWithTwoPoliciesAndPostureChecks(t *testing.T) {
// should allow peer1 and peer2 to match the policy
newPolicy := &Policy{
ID: "policy2ID",
AccountID: "accountID",
AccountID: accID,
Enabled: true,
Rules: []*PolicyRule{
{
ID: "policy2ID",
Enabled: true,
Sources: []string{"group1"},
Sources: []string{group1ID},
DestinationResource: Resource{
ID: "resource1ID",
ID: accNetResource1ID,
Type: "Host",
},
Protocol: PolicyRuleProtocolTCP,
Expand All @@ -672,7 +676,7 @@ func Test_NetworksNetMapGenWithTwoPoliciesAndPostureChecks(t *testing.T) {
assert.Len(t, sourcePeers, 0, "expected source peers don't match")

isRouter, networkResourcesRoutes, sourcePeers = account.GetNetworkResourcesRoutesToSync(context.Background(), accNetResourceRouter1ID, account.GetResourcePoliciesMap(), account.GetResourceRoutersMap())
rules := account.GetPeerNetworkResourceFirewallRules(context.Background(), account.Peers["router1"], accNetResourceValidPeers, networkResourcesRoutes, account.GetResourcePoliciesMap())
rules := account.GetPeerNetworkResourceFirewallRules(context.Background(), account.Peers[accNetResourceRouter1ID], accNetResourceValidPeers, networkResourcesRoutes, account.GetResourcePoliciesMap())
assert.True(t, isRouter, "should be router")
assert.Len(t, networkResourcesRoutes, 1, "expected network resource route don't match")
assert.Len(t, sourcePeers, 2, "expected source peers don't match")
Expand Down Expand Up @@ -716,7 +720,7 @@ func Test_NetworksNetMapGenWithTwoPostureChecks(t *testing.T) {
assert.Len(t, sourcePeers, 0, "expected source peers don't match")

isRouter, networkResourcesRoutes, sourcePeers = account.GetNetworkResourcesRoutesToSync(context.Background(), accNetResourceRouter1ID, account.GetResourcePoliciesMap(), account.GetResourceRoutersMap())
rules := account.GetPeerNetworkResourceFirewallRules(context.Background(), account.Peers["router1"], accNetResourceValidPeers, networkResourcesRoutes, account.GetResourcePoliciesMap())
rules := account.GetPeerNetworkResourceFirewallRules(context.Background(), account.Peers[accNetResourceRouter1ID], accNetResourceValidPeers, networkResourcesRoutes, account.GetResourcePoliciesMap())
assert.True(t, isRouter, "should be router")
assert.Len(t, networkResourcesRoutes, 1, "expected network resource route don't match")
assert.Len(t, sourcePeers, 1, "expected source peers don't match")
Expand Down

0 comments on commit 6fe4529

Please sign in to comment.