MySQL Support

[ismail0234]

Describe your changes

MySQL support for Netbird. Still in draft stage. I have never used the “GO” language before, so if I have any mistakes you can help me to correct them.

Issue ticket number and link

• MariaDB/MySQL Support #2655

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)
• Extended the README / documentation, if necessary

[CLAassistant]

All committers have signed the CLA.

[ismail0234]

I'm working on it, and from what I've seen, adding mysql support seems to be pretty straightforward. But I haven't tested it yet and I'm not sure if it will work, so it's still in draft stage. Can someone tell me how to compile and test on the server side?

[mlsmaycon]

Thanks for the submission @ismail0234. Can you enable github action tests for MySQL as well?

See the current ones here:

netbird/.github/workflows/golang-test-linux.yml

Line 13 in 4e918e5

jobs:

[mlsmaycon]

@bcmmbaga can you share how to add a testcontainer for MySQL?

[bcmmbaga]

@ismail0234 To add a MySQL test container, you will need to add MySQL support in the NewTestStoreFromSQL

netbird/management/server/store.go

Line 253 in a9d06b8

func NewTestStoreFromSQL(ctx context.Context, filename string, dataDir string) (Store, func(), error) {

To spin up a new MySQL test container, you can follow the same approach we used for PostgreSQL

netbird/management/server/testutil/store.go

Line 17 in a9d06b8

func CreatePGDB() (func(), error) {

[ismail0234]

The “security/snyk” step seems to have failed but I can't see what caused it.

[bcmmbaga]

The “security/snyk” step seems to have failed but I can't see what caused it.

Go modules seem out of sync with the codebase. Could you run go mod tidy and push the changes?

[ismail0234]

hmm, the result still seems to be the same.

[ismail0234]

Is this part used for testing? Do I need to add mysql values?

netbird/.github/workflows/test-infrastructure-files.yml

Line 23 in a9d06b8

store: [ 'sqlite', 'postgres' ]

netbird/.github/workflows/test-infrastructure-files.yml

Lines 40 to 44 in a9d06b8

	if [ "${{ matrix.store }}" == "postgres" ]; then
	echo "NETBIRD_STORE_ENGINE_POSTGRES_DSN=host=$(hostname -I | awk '{print $1}') user=netbird password=postgres dbname=netbird port=5432" >> $GITHUB_ENV
	else
	echo "NETBIRD_STORE_ENGINE_POSTGRES_DSN==" >> $GITHUB_ENV
	fi

[ismail0234]

@mlsmaycon @bcmmbaga @pascal-fischer Can you check the Pull Request to merge?

[ismail0234]

If you want to merge PR, I reopened it. But if you don't want to merge, you can close or delete PR. @mlsmaycon

[bcmmbaga]

@ismail0234, could you please run the following commands and push the changes?

 go get -u github.com/containerd/containerd && go mod tidy 

[ismail0234]

@ismail0234, could you please run the following commands and push the changes?

 go get -u github.com/containerd/containerd && go mod tidy 

The vulnerability appears to be in the go-jose module. The vulnerability has been fixed on version v4.0.1. Even if containerd is updated, the issue still seems to persist.

[bcmmbaga]

The vulnerability appears to be in the go-jose module. The vulnerability has been fixed on version v4.0.1. Even if containerd is updated, the issue still seems to persist.

You can revert the changes since they broke the gRPC. However, the Snyk issue seems to be a false positive, as we don't import the go-jose module at all. You can confirm with:

go mod why -m github.com/go-jose/go-jose

I'll take a closer look into this as well

[ismail0234]

The vulnerability appears to be in the go-jose module. The vulnerability has been fixed on version v4.0.1. Even if containerd is updated, the issue still seems to persist.

You can revert the changes since they broke the gRPC. However, the Snyk issue seems to be a false positive, as we don't import the go-jose module at all. You can confirm with:

go mod why -m github.com/go-jose/go-jose

I'll take a closer look into this as well

@bcmmbaga yes, it says the module is not in use.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[ismail0234]

@bcmmbaga It seems that the module you mentioned is not used because it is a different module. But there is a “go-jose” module with a different name in the modules list.

netbird/go.mod

Line 228 in 37ad370

gopkg.in/square/go-jose.v2 v2.6.0 // indirect

This module appears to be in use.