Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[management] Refactor peers to use store methods #2893

Merged
merged 132 commits into from
Jan 20, 2025
Merged
Changes from 1 commit
Commits
Show all changes
132 commits
Select commit Hold shift + click to select a range
389c961
Refactor setup key handling to use store methods
bcmmbaga Nov 7, 2024
78044c2
add lock to get account groups
bcmmbaga Nov 7, 2024
1a5f3c6
add check for regular user
bcmmbaga Nov 7, 2024
931521d
get only required groups for auto-group validation
bcmmbaga Nov 7, 2024
f8b5eed
add account lock and return auto groups map on validation
bcmmbaga Nov 8, 2024
106fc75
refactor account peers update
bcmmbaga Nov 8, 2024
0a70e4c
Refactor groups to use store methods
bcmmbaga Nov 8, 2024
8126d95
refactor GetGroupByID and add NewGroupNotFoundError
bcmmbaga Nov 8, 2024
ac05f69
fix tests
bcmmbaga Nov 8, 2024
40af1a5
Merge branch 'feature/get-account-refactoring' into setupkey-get-acco…
bcmmbaga Nov 8, 2024
d58cf50
Merge branch 'setupkey-get-account-refactoring' into groups-get-accou…
bcmmbaga Nov 8, 2024
7100be8
Add AddPeer and RemovePeer methods to Group struct
bcmmbaga Nov 8, 2024
6dc185e
Preserve store engine in SqlStore transactions
bcmmbaga Nov 8, 2024
bdeb95c
Run groups ops in transaction
bcmmbaga Nov 8, 2024
3ed8b9c
fix missing group removed from setup key activity
bcmmbaga Nov 8, 2024
cc04aef
Merge branch 'setupkey-get-account-refactoring' into groups-get-accou…
bcmmbaga Nov 8, 2024
871500c
fix merge
bcmmbaga Nov 8, 2024
174e07f
Refactor posture checks to remove get and save account
bcmmbaga Nov 11, 2024
d54b696
fix refactor
bcmmbaga Nov 11, 2024
601d429
fix tests
bcmmbaga Nov 11, 2024
010a8bf
Merge branch 'main' into groups-get-account-refactoring
bcmmbaga Nov 11, 2024
664d138
fix merge
bcmmbaga Nov 11, 2024
ab00c41
fix sonar
bcmmbaga Nov 11, 2024
113c21b
Change setup key log level to debug for missing group
bcmmbaga Nov 11, 2024
d23b5c8
Retrieve modified peers once for group events
bcmmbaga Nov 11, 2024
ffce48c
Merge branch 'groups-get-account-refactoring' into policy-get-account…
bcmmbaga Nov 11, 2024
0c0fd38
Refactor policy get and save account to use store methods
bcmmbaga Nov 12, 2024
2d7f08c
Fix tests
bcmmbaga Nov 12, 2024
2806d73
Add tests
bcmmbaga Nov 12, 2024
00023bf
Merge branch 'groups-get-account-refactoring' into posturechecks-get-…
bcmmbaga Nov 12, 2024
a3abc21
Add tests
bcmmbaga Nov 12, 2024
ed259a6
Merge branch 'main' into groups-get-account-refactoring
bcmmbaga Nov 12, 2024
147971f
Merge branch 'groups-get-account-refactoring' into policy-get-account…
bcmmbaga Nov 12, 2024
446de5e
Merge branch 'groups-get-account-refactoring' into posturechecks-get-…
bcmmbaga Nov 12, 2024
2a59f04
Merge branch 'posturechecks-get-account-refactoring' into policy-get-…
bcmmbaga Nov 12, 2024
32d1b2d
Retrieve policy groups and posture checks once for validation
bcmmbaga Nov 12, 2024
bbaee18
Fix typo
bcmmbaga Nov 12, 2024
50e6389
Merge branch 'posturechecks-get-account-refactoring' into policy-get-…
bcmmbaga Nov 12, 2024
3a915de
Add policy tests
bcmmbaga Nov 12, 2024
9872bee
Refactor anyGroupHasPeers to retrieve all groups once
bcmmbaga Nov 12, 2024
9bc8e6e
Merge branch 'posturechecks-get-account-refactoring' into policy-get-…
bcmmbaga Nov 12, 2024
5601905
Refactor dns settings to use store methods
bcmmbaga Nov 13, 2024
4b943c3
Add tests
bcmmbaga Nov 13, 2024
ed047ec
Add account locking and merge group deletion methods
bcmmbaga Nov 13, 2024
a4d905f
Fix tests
bcmmbaga Nov 13, 2024
218345e
Refactor name server groups to use store methods
bcmmbaga Nov 13, 2024
ef55b9e
Add tests
bcmmbaga Nov 13, 2024
6315644
Add peer store methods
bcmmbaga Nov 14, 2024
8420a52
Refactor ephemeral peers
bcmmbaga Nov 14, 2024
f5e7449
Add lock for peer store methods
bcmmbaga Nov 14, 2024
7d849a9
Refactor peer handlers
bcmmbaga Nov 14, 2024
c557c98
Refactor peer to use store methods
bcmmbaga Nov 14, 2024
f6f7260
Fix tests
bcmmbaga Nov 14, 2024
92b9e11
Merge branch 'main' into groups-get-account-refactoring
bcmmbaga Nov 15, 2024
4ef3890
Fix typo
bcmmbaga Nov 15, 2024
51c1ec2
Add locks and remove log
bcmmbaga Nov 15, 2024
1ff8f61
Merge branch 'main' into groups-get-account-refactoring
bcmmbaga Nov 15, 2024
d4c7124
Merge branch 'groups-get-account-refactoring' into posturechecks-get-…
bcmmbaga Nov 15, 2024
a61e9da
run peer ops in transaction
bcmmbaga Nov 18, 2024
a2fb274
remove duplicate store method
bcmmbaga Nov 18, 2024
a2a49bd
fix peer fields updated after save
bcmmbaga Nov 18, 2024
48edfa6
add tests
bcmmbaga Nov 18, 2024
6dd56e3
Merge branch 'posturechecks-get-account-refactoring' into policy-get-…
bcmmbaga Nov 18, 2024
ec6438e
Use update strength and simplify check
bcmmbaga Nov 18, 2024
df98c67
prevent changing ruleID when not empty
bcmmbaga Nov 18, 2024
b60e2c3
prevent duplicate rules during updates
bcmmbaga Nov 18, 2024
20fc8e8
fix tests
bcmmbaga Nov 18, 2024
0ee56e1
fix lint
bcmmbaga Nov 19, 2024
82746d9
Use UTC time in test
bcmmbaga Nov 21, 2024
bdb2a76
Merge branch 'main' into policy-get-account-refactoring
bcmmbaga Nov 25, 2024
79822cd
Merge branch 'policy-get-account-refactoring' into dns-get-account-re…
bcmmbaga Nov 25, 2024
72bfc9d
Merge branch 'dns-get-account-refactoring' into nameserver-get-accoun…
bcmmbaga Nov 25, 2024
2e6bbac
Merge branch 'main' into nameserver-get-account-refactoring
bcmmbaga Nov 26, 2024
b213987
Merge branch 'nameserver-get-account-refactoring' into peers-get-acco…
bcmmbaga Nov 27, 2024
21561a2
Merge branch 'main' into peers-get-account-refactoring
bcmmbaga Nov 27, 2024
fde9f2f
Add store locks and prevent fetching setup keys peers when retrieving…
bcmmbaga Nov 28, 2024
a22d504
Add missing tests
bcmmbaga Nov 28, 2024
cde0e51
Refactor test names and remove duplicate TestPostgresql_SavePeerStatus
bcmmbaga Nov 28, 2024
f87bc60
Add account locks and remove redundant ephemeral check
bcmmbaga Nov 28, 2024
1ba6eb6
Retrieve all groups for peers and restrict groups for regular users
bcmmbaga Nov 28, 2024
dea6886
Merge branch 'main' into peers-get-account-refactoring
bcmmbaga Nov 28, 2024
d66140f
Fix merge
bcmmbaga Nov 28, 2024
8c4613b
Merge branch 'main' into peers-get-account-refactoring
bcmmbaga Nov 28, 2024
a3663fb
Merge branch 'main' into peers-get-account-refactoring
bcmmbaga Nov 29, 2024
a05bd46
Merge branch 'main' into peers-get-account-refactoring
bcmmbaga Dec 6, 2024
9a96b91
Fix merge
bcmmbaga Dec 9, 2024
9d86f76
Merge branch 'main' into peers-get-account-refactoring
bcmmbaga Jan 8, 2025
baf2112
fix merge
bcmmbaga Jan 8, 2025
fa1eaa0
fix store tests
bcmmbaga Jan 9, 2025
2e596fb
use account object to get validated peers
bcmmbaga Jan 10, 2025
b132526
Merge branch 'main' into peers-get-account-refactoring
bcmmbaga Jan 13, 2025
d1e5d58
Fix merge
bcmmbaga Jan 13, 2025
3cc6d38
Improve peer performance
bcmmbaga Jan 13, 2025
48af90c
Get account direct from store without buffer
bcmmbaga Jan 13, 2025
c603c40
Add get peer groups tests
bcmmbaga Jan 13, 2025
7a9c75d
Adjust benchmarks
bcmmbaga Jan 13, 2025
eb062c0
Adjust benchmarks
bcmmbaga Jan 14, 2025
aa0480c
[management] Update benchmark workflow (#3181)
pascal-fischer Jan 14, 2025
47a18db
update local benchmark expectations
pascal-fischer Jan 14, 2025
9ff56ea
update cloud expectations
pascal-fischer Jan 14, 2025
cd15c85
Add status error for generic result error
bcmmbaga Jan 14, 2025
ce73851
Use integrated validator direct
bcmmbaga Jan 14, 2025
3483139
update expectations
pascal-fischer Jan 14, 2025
2706ede
update expectations
pascal-fischer Jan 14, 2025
8b7766e
update expectations
pascal-fischer Jan 14, 2025
acb5340
Merge remote-tracking branch 'origin/peers-get-account-refactoring' i…
bcmmbaga Jan 14, 2025
84aea32
Refactor peer scheduler to retry every 3 seconds on errors
bcmmbaga Jan 14, 2025
29ea44b
update expectations
pascal-fischer Jan 14, 2025
61b38e5
fix validator
pascal-fischer Jan 14, 2025
a5731fe
fix validator
pascal-fischer Jan 14, 2025
44f69c7
fix validator
pascal-fischer Jan 14, 2025
b1e8ed8
update timeouts
pascal-fischer Jan 14, 2025
b15ee5c
Refactor ToGroupsInfo to process slices of groups
bcmmbaga Jan 14, 2025
7baef8c
Merge remote-tracking branch 'origin/peers-get-account-refactoring' i…
bcmmbaga Jan 14, 2025
30b023d
update expectations
pascal-fischer Jan 14, 2025
7241a16
Merge remote-tracking branch 'origin/peers-get-account-refactoring' i…
pascal-fischer Jan 14, 2025
167c80d
update expectations
pascal-fischer Jan 14, 2025
e27db94
update expectations
pascal-fischer Jan 14, 2025
6a81ca2
Bump integrations version
bcmmbaga Jan 15, 2025
2fb399a
Refactor GetValidatedPeers
bcmmbaga Jan 15, 2025
22798ad
Fix tests
bcmmbaga Jan 15, 2025
6367fe4
go mod tidy
bcmmbaga Jan 15, 2025
4afaabb
Use peers and groups map for peers validation
bcmmbaga Jan 15, 2025
aeb6e53
remove mysql from api benchmark tests
pascal-fischer Jan 15, 2025
30ae3aa
Skip user check for system initiated peer deletion
bcmmbaga Jan 16, 2025
d962f7f
Remove context in db calls
bcmmbaga Jan 16, 2025
97ff9a3
[management] Improve group peer/resource counting (#3192)
pascal-fischer Jan 16, 2025
93c8f94
add metrics
pascal-fischer Jan 17, 2025
232c978
revert: add some logs
pascal-fischer Jan 17, 2025
5acfe00
Merge branch 'main' into peers-get-account-refactoring
pascal-fischer Jan 17, 2025
f1ee844
fix import
pascal-fischer Jan 17, 2025
9af9573
[management] extract getSettings calls from transactions (#3206)
pascal-fischer Jan 18, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Preserve store engine in SqlStore transactions
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
  • Loading branch information
bcmmbaga committed Nov 8, 2024
commit 6dc185e141c4e10c64c8879f54a8338fd4e4c01d
3 changes: 2 additions & 1 deletion management/server/sql_store.go
Original file line number Diff line number Diff line change
@@ -1116,7 +1116,8 @@ func (s *SqlStore) ExecuteInTransaction(ctx context.Context, operation func(stor

func (s *SqlStore) withTx(tx *gorm.DB) Store {
return &SqlStore{
db: tx,
db: tx,
storeEngine: s.storeEngine,
}
}