Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] use embedded root CA if system certpool is empty #3272

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

hakansa
Copy link
Contributor

@hakansa hakansa commented Feb 2, 2025

use embedded root CA if system certpool is empty

Describe your changes

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

client/internal/auth/device_flow.go Outdated Show resolved Hide resolved
util/embeddedroots/embeddedroots.go Outdated Show resolved Hide resolved
lixmal
lixmal previously approved these changes Feb 3, 2025
Copy link

sonarqubecloud bot commented Feb 3, 2025

@hakansa hakansa marked this pull request as ready for review February 3, 2025 15:53
@hakansa hakansa merged commit 0125cd9 into main Feb 4, 2025
40 of 41 checks passed
@hakansa hakansa deleted the feature/embeddedrootca-fallback branch February 4, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants