feat: set entity timestamp (at source) if not provided #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Coverage Report
|
ltucker
approved these changes
Jan 24, 2025
leoparente
approved these changes
Jan 24, 2025
mfiedorowicz
deleted the
feat-set-entity-current-timestamp-if-not-provided
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
netboxlabs/diode/sdk/ingester.pyfile, test coverage improvements intests/test_ingester.py, and an update to the.github/CODEOWNERSfile. The most important changes include adding a check forNonetimestamps, updating the code owners, and adding new test cases for entity instantiation.Codebase improvements:
netboxlabs/diode/sdk/ingester.py: Added a check to handleNonetimestamps by setting the current time if no timestamp is provided.Test coverage improvements:
tests/test_ingester.py: Added import fortimestamp_pb2fromgoogle.protobuf.tests/test_ingester.py: Added a test casetest_entity_instantiation_with_no_timestamp_providedto ensure that an entity is instantiated correctly when no timestamp is provided.tests/test_ingester.py: Added a test casetest_entity_instantiation_with_timestamp_providedto validate entity instantiation with a provided timestamp.Code ownership:
.github/CODEOWNERS: Updated the code owners to include@ltuckeralong with existing owners@leoparenteand@mfiedorowicz.