Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement orb discovery #1

Merged
merged 20 commits into from
Nov 8, 2024
Merged

feat: implement orb discovery #1

merged 20 commits into from
Nov 8, 2024

Conversation

leoparente
Copy link
Contributor

No description provided.

@leoparente leoparente self-assigned this Oct 28, 2024
@linear Linear
Copy link

linear bot commented Oct 28, 2024

OBS-547 Create discovery backend based on diode-napalm-agent

Create discovery backend based on diode-napalm-agent. Needs to implement the policy manager and rest api using python FastAPI.

jit-ci[bot]
jit-ci bot reviewed Oct 28, 2024
View reviewed changes
Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 1 important finding in this PR that you should review.
The finding is detailed below as a comment.
It’s highly recommended that you fix this security issue before merge.

orb-discovery/tests/test_parser.py Show resolved Hide resolved
jit-ci[bot]
jit-ci bot reviewed Nov 1, 2024
View reviewed changes
Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 4 important findings in this PR that you should review.
The findings are detailed as separate comments.
It’s highly recommended that you fix these security issues before merge.

Until now, you ignored/fixed 1 finding.

orb-discovery/tests/policy/test_manager.py Show resolved Hide resolved
orb-discovery/tests/test_server.py Show resolved Hide resolved
orb-discovery/tests/test_server.py Show resolved Hide resolved
orb-discovery/tests/test_server.py Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
orb_discovery
   discovery.py36294%93–96
   main.py25196%59
   parser.py43295%54, 87
   server.py68494%33–35, 128, 131
   version.py7186%14
orb_discovery/policy
   runner.py64198%49
TOTAL3881197% 

Tests Skipped Failures Errors Time
56 0 💤 0 ❌ 0 🔥 6.037s ⏱️

@leoparente leoparente marked this pull request as ready for review November 4, 2024 18:22
mfiedorowicz
mfiedorowicz reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leoparente, a few clarifying questions and suggestions to consider (if applicable) 👍

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
orb-discovery/orb_discovery/client.py Outdated Show resolved Hide resolved
orb-discovery/orb_discovery/policy/runner.py Outdated Show resolved Hide resolved
orb-discovery/orb_discovery/policy/runner.py Outdated Show resolved Hide resolved
orb-discovery/orb_discovery/policy/runner.py Outdated Show resolved Hide resolved
orb-discovery/orb_discovery/server.py Outdated Show resolved Hide resolved
orb-discovery/tests/test_server.py Outdated Show resolved Hide resolved
leoparente and others added 2 commits November 6, 2024 14:05
@leoparente @mfiedorowicz
Apply suggestions from code review
a10b206 
Co-authored-by: Michal Fiedorowicz <michal@codefella.com>
@leoparente
Change config
2ac5d9f
jit-ci[bot]
jit-ci bot reviewed Nov 7, 2024
View reviewed changes
Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 1 important finding in this PR that you should review.
The finding is detailed as a comment.
It’s highly recommended that you fix this security issue before merge.

Until now, you ignored/fixed 5 findings.

orb-discovery/docker/Dockerfile Show resolved Hide resolved
@mfiedorowicz mfiedorowicz changed the title feat: Implement orb discovery feat: implement orb discovery Nov 7, 2024
mfiedorowicz
mfiedorowicz reviewed Nov 7, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
mfiedorowicz
mfiedorowicz approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks Leo

@leoparente leoparente merged commit a8006a7 into develop Nov 8, 2024
8 checks passed
@leoparente leoparente deleted the feat/OBS-547-implement-orb-discovery branch November 8, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jit-ci jit-ci[bot] jit-ci[bot] left review comments

@mfiedorowicz mfiedorowicz mfiedorowicz approved these changes

@weyrick weyrick Awaiting requested review from weyrick

Assignees

@leoparente leoparente

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leoparente @mfiedorowicz