Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: submodules drivers load for custom napalm packages #58

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

leoparente
Copy link
Contributor

This pull request includes several changes to enhance the discovery of NAPALM drivers and improve the testing framework. The most important changes include the addition of a new function to walk through NAPALM packages, modifications to the napalm_driver_list function, and updates to the test cases to ensure comprehensive coverage.

Enhancements to NAPALM driver discovery:

Dependency updates:

Improvements to test cases:

@leoparente leoparente self-assigned this Jan 23, 2025
Copy link

github-actions bot commented Jan 23, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
device_discovery
   discovery.py63297%142–145
   main.py32294%90, 96
   server.py68494%33–35, 128, 131
   version.py7186%14
device_discovery/policy
   manager.py41295%36–37
   runner.py66198%49
TOTAL4291297% 

Tests Skipped Failures Errors Time
54 0 💤 0 ❌ 0 🔥 6.119s ⏱️

@leoparente leoparente marked this pull request as ready for review January 23, 2025 19:49
@leoparente leoparente merged commit f51eda1 into develop Jan 23, 2025
7 checks passed
@leoparente leoparente deleted the fix/submodules-napalm-driver branch January 23, 2025 20:08
Copy link

🎉 This PR is included in version 0.4.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 0.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants