fix: correct redirect conditions type (#3908)

netlify · Dec 1, 2021 · 0bdb973 · 0bdb973
1 parent 419afda
commit 0bdb973
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/build/test-d/config/netlify_config.ts b/packages/build/test-d/config/netlify_config.ts
@@ -50,7 +50,10 @@ const testNetlifyConfigRedirects: OnPreBuild = function ({
   expectType<string | undefined>(redirect.signed)
   expectType<string | undefined>(redirect.query && redirect.query.testVar)
   expectType<string | undefined>(redirect.headers && redirect.headers.testVar)
-  expectType<readonly string[] | undefined>(
-    redirect.conditions && redirect.conditions.language && redirect.conditions.language,
-  )
+  if (redirect.conditions !== undefined) {
+    expectType<readonly string[] | undefined>(redirect.conditions.Language)
+    expectType<readonly string[] | undefined>(redirect.conditions.Cookie)
+    expectType<readonly string[] | undefined>(redirect.conditions.Country)
+    expectType<readonly string[] | undefined>(redirect.conditions.Role)
+  }
 }
diff --git a/packages/build/types/config/netlify_config.d.ts b/packages/build/types/config/netlify_config.d.ts
@@ -14,7 +14,7 @@ interface Redirect {
   signed?: string
   query?: Partial<Record<string, string>>
   headers?: Partial<Record<string, string>>
-  conditions?: Record<'language' | 'role' | 'country', readonly string[]>
+  conditions?: Partial<Record<'Language' | 'Role' | 'Country' | 'Cookie', readonly string[]>>
 }
 
 interface Header {