Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added callback to allow reattaching slider after AJAX load. #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alinistrate
Copy link

@sun sun changed the title Added event listener for Woocommerce Related Accessories AJAX load. Added callback to allow reattaching slider after AJAX load. Aug 3, 2022
* Initialize gallerya slider
*/
function initSlider() {
// Adds slide navigation through variation thumbnails for variable products
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea to do in general, but can you move the code back up to its original position in the file?

});
}

// Reinitialize slider for Woocommerce Related Accessories
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The event actually doesn't seem to be related to related-accessories, so we should drop its name from the comment here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants