Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I have recently reproduced your work and successfully obtained the results you provided. However, I encountered several issues during the reproduction, so I have corrected some errors in the README according to my reproduction steps:
'pip install requirements.txt'
'conda install -c conda-forge faiss-gpu=1.7.2'
. In fact, the original README's method of installing faiss withrequirements.txt
is problematic, leading to high ppl reproduction in knnlm.accelerate
, which has been added.--dstore_size 116988150
to steps 3 and 4 to avoid errors.