Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README file #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update README file #19

wants to merge 2 commits into from

Conversation

dioloib
Copy link

@dioloib dioloib commented Dec 7, 2024

Hello, I have recently reproduced your work and successfully obtained the results you provided. However, I encountered several issues during the reproduction, so I have corrected some errors in the README according to my reproduction steps:

  1. Adding the recommended Python version: Python <= 3.10. The corresponding version of faiss cannot be installed in Python 3.11.
  2. Corrected some spelling errors. Like 'pip install requirements.txt'
  3. FAISS installation: FAISS should be installed using 'conda install -c conda-forge faiss-gpu=1.7.2'. In fact, the original README's method of installing faiss with requirements.txt is problematic, leading to high ppl reproduction in knnlm.
  4. Adding missing dependency: The requirements were missing accelerate, which has been added.
  5. Adding explanations for steps 2 and 3.
  6. Adding a parameter to avoid errors: Add a parameter --dstore_size 116988150 to steps 3 and 4 to avoid errors.

@dioloib dioloib closed this Dec 7, 2024
@dioloib dioloib reopened this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant